[GitHub] [dolphinscheduler] JinyLeeChina commented on a change in pull request #6592: [DS-6591][API] Fix process definition import

[GitBox <gi...@apache.org>]

JinyLeeChina commented on a change in pull request #6592:
URL: https://github.com/apache/dolphinscheduler/pull/6592#discussion_r735695925



##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
##########
@@ -849,6 +849,8 @@ private boolean checkAndImport(User loginUser, long projectCode, Map<String, Obj
         }
         String processDefinitionName = recursionProcessDefinitionName(projectCode, processDefinition.getName(), 1);
         processDefinition.setName(processDefinitionName + "_import_" + DateUtils.getCurrentTimeStamp());
+        processDefinition.setId(0);

Review comment:
       Very good
   I think the exports should also be optimized, like id and other unnecessary information




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org