You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/01/26 02:52:59 UTC
[GitHub] [shardingsphere] lanchengx opened a new pull request #15074: [DistSQL] Add `drop traffic rule` syntax parse test.
lanchengx opened a new pull request #15074:
URL: https://github.com/apache/shardingsphere/pull/15074
For https://github.com/apache/shardingsphere/issues/15018.
Changes proposed in this pull request:
- Add `drop traffic rule` syntax parse test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a change in pull request #15074: [DistSQL] Add `drop traffic rule` syntax parse test.
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on a change in pull request #15074:
URL: https://github.com/apache/shardingsphere/pull/15074#discussion_r792295959
##########
File path: shardingsphere-test/shardingsphere-parser-test/src/main/resources/sql/supported/ral/common.xml
##########
@@ -40,4 +40,5 @@
<distsql-case id="show-sql-parser-rule" value="SHOW SQL_PARSER RULE" />
<distsql-case id="alter-sql-parser-rule" value="ALTER SQL_PARSER RULE SQL_COMMENT_PARSE_ENABLE=false,PARSE_TREE_CACHE(INITIAL_CAPACITY=10, MAXIMUM_SIZE=11,CONCURRENCY_LEVEL=1), SQL_STATEMENT_CACHE(INITIAL_CAPACITY=11, MAXIMUM_SIZE=11,CONCURRENCY_LEVEL=100)" />
<distsql-case id="show-traffic-rules" value="SHOW TRAFFIC RULE rule_name" />
+ <distsql-case id="drop-traffic-rule" value="Drop traffic rule rule_name" />
Review comment:
Please change the key words to uppercase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #15074: [DistSQL] Add `drop traffic rule` syntax parse test.
Posted by GitBox <gi...@apache.org>.
RaigorJiang merged pull request #15074:
URL: https://github.com/apache/shardingsphere/pull/15074
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org