You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2016/04/19 20:38:57 UTC
Review Request 46401: Corrected acls protobuf file in documentation
and flag.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46401/
-----------------------------------------------------------
Review request for mesos, Adam B, Alexander Rojas, and Greg Mann.
Repository: mesos
Description
-------
The acls protobuf messages have moved from
authorization.proto to acls.proto. This patch reflects
this change in the documentation/flag.
Diffs
-----
docs/configuration.md cd9733002a0940f44edd4e56593a0ca3fe9f77f5
src/master/flags.cpp e6a239c15f52b381a83cc359d8b5a335a5fbd0af
Diff: https://reviews.apache.org/r/46401/diff/
Testing
-------
Thanks,
Joerg Schad
Re: Review Request 46401: Corrected acls protobuf file in
documentation and flag.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46401/#review129697
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On April 19, 2016, 11:38 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46401/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 11:38 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The acls protobuf messages have moved from
> authorization.proto to acls.proto. This patch reflects
> this change in the documentation/flag.
>
>
> Diffs
> -----
>
> docs/configuration.md cd9733002a0940f44edd4e56593a0ca3fe9f77f5
> src/master/flags.cpp e6a239c15f52b381a83cc359d8b5a335a5fbd0af
>
> Diff: https://reviews.apache.org/r/46401/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 46401: Corrected acls protobuf file in
documentation and flag.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46401/#review129659
-----------------------------------------------------------
Patch looks great!
Reviews applied: [46401]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 19, 2016, 6:38 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46401/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 6:38 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The acls protobuf messages have moved from
> authorization.proto to acls.proto. This patch reflects
> this change in the documentation/flag.
>
>
> Diffs
> -----
>
> docs/configuration.md cd9733002a0940f44edd4e56593a0ca3fe9f77f5
> src/master/flags.cpp e6a239c15f52b381a83cc359d8b5a335a5fbd0af
>
> Diff: https://reviews.apache.org/r/46401/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 46401: Corrected acls protobuf file in
documentation and flag.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46401/#review129590
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On April 19, 2016, 6:38 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46401/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 6:38 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The acls protobuf messages have moved from
> authorization.proto to acls.proto. This patch reflects
> this change in the documentation/flag.
>
>
> Diffs
> -----
>
> docs/configuration.md cd9733002a0940f44edd4e56593a0ca3fe9f77f5
> src/master/flags.cpp e6a239c15f52b381a83cc359d8b5a335a5fbd0af
>
> Diff: https://reviews.apache.org/r/46401/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joerg Schad
>
>