You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Daniel Becker (Code Review)" <ge...@cloudera.org> on 2023/04/19 14:32:41 UTC
[Impala-ASF-CR] IMPALA-12074: Add the WARN UNUSED RESULT attribute to methods of BitWriter that can fail
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19771
Change subject: IMPALA-12074: Add the WARN_UNUSED_RESULT attribute to methods of BitWriter that can fail
......................................................................
IMPALA-12074: Add the WARN_UNUSED_RESULT attribute to methods of BitWriter that can fail
Many methods of BitWriter signal failure via the return value. These
return values should not be discarded because the failures are not
detected then.
This change adds the 'WARN_UNUSED_RESULT' attribute to these methods so
the compiler can check that the return value is not discarded.
Change-Id: I97ddba8057f71b6ebbed5b89b12d81c659ce98ae
---
M be/src/exec/parquet/parquet-bool-decoder.cc
M be/src/util/bit-stream-utils-test.cc
M be/src/util/bit-stream-utils.h
M be/src/util/rle-encoding.h
M be/src/util/rle-test.cc
5 files changed, 21 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/19771/1
--
To view, visit http://gerrit.cloudera.org:8080/19771
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I97ddba8057f71b6ebbed5b89b12d81c659ce98ae
Gerrit-Change-Number: 19771
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-12074: Add the WARN UNUSED RESULT attribute to methods of BitWriter that can fail
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19771 )
Change subject: IMPALA-12074: Add the WARN_UNUSED_RESULT attribute to methods of BitWriter that can fail
......................................................................
IMPALA-12074: Add the WARN_UNUSED_RESULT attribute to methods of BitWriter that can fail
Many methods of BitWriter signal failure via the return value. These
return values should not be discarded because the failures are not
detected then.
This change adds the 'WARN_UNUSED_RESULT' attribute to these methods so
the compiler can check that the return value is not discarded.
Change-Id: I97ddba8057f71b6ebbed5b89b12d81c659ce98ae
Reviewed-on: http://gerrit.cloudera.org:8080/19771
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/parquet/parquet-bool-decoder.cc
M be/src/util/bit-stream-utils-test.cc
M be/src/util/bit-stream-utils.h
M be/src/util/rle-encoding.h
M be/src/util/rle-test.cc
5 files changed, 21 insertions(+), 13 deletions(-)
Approvals:
Csaba Ringhofer: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19771
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I97ddba8057f71b6ebbed5b89b12d81c659ce98ae
Gerrit-Change-Number: 19771
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-12074: Add the WARN UNUSED RESULT attribute to methods of BitWriter that can fail
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19771 )
Change subject: IMPALA-12074: Add the WARN_UNUSED_RESULT attribute to methods of BitWriter that can fail
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19771
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I97ddba8057f71b6ebbed5b89b12d81c659ce98ae
Gerrit-Change-Number: 19771
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Apr 2023 13:16:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12074: Add the WARN UNUSED RESULT attribute to methods of BitWriter that can fail
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19771 )
Change subject: IMPALA-12074: Add the WARN_UNUSED_RESULT attribute to methods of BitWriter that can fail
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9237/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/19771
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I97ddba8057f71b6ebbed5b89b12d81c659ce98ae
Gerrit-Change-Number: 19771
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Apr 2023 08:06:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12074: Add the WARN UNUSED RESULT attribute to methods of BitWriter that can fail
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19771 )
Change subject: IMPALA-12074: Add the WARN_UNUSED_RESULT attribute to methods of BitWriter that can fail
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12819/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19771
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I97ddba8057f71b6ebbed5b89b12d81c659ce98ae
Gerrit-Change-Number: 19771
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Apr 2023 14:54:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12074: Add the WARN UNUSED RESULT attribute to methods of BitWriter that can fail
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19771 )
Change subject: IMPALA-12074: Add the WARN_UNUSED_RESULT attribute to methods of BitWriter that can fail
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19771
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I97ddba8057f71b6ebbed5b89b12d81c659ce98ae
Gerrit-Change-Number: 19771
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Apr 2023 16:35:19 +0000
Gerrit-HasComments: No