You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Yida Wu (Code Review)" <ge...@cloudera.org> on 2022/03/18 01:12:43 UTC

[Impala-ASF-CR] IMPALA-11193: Fix assertion failure of ClientCacheTest.MemLeak in CentOS

Yida Wu has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18332 )

Change subject: IMPALA-11193: Fix assertion failure of ClientCacheTest.MemLeak in CentOS
......................................................................

IMPALA-11193: Fix assertion failure of ClientCacheTest.MemLeak in CentOS

The assertion failure happens in CentOS because the testcase
reads the virtual memory usage of the current thread from
/proc/thread-self. However, CentOS may not contain this symlink,
therefore the testcase is not able to locate the path and
then triggers the assertion.

This fix changes the path to /proc/self, which is a symlink to the
current process and available in CentOS. Because the testcase
doesn't involve multithreading, it is okay to replace the
/proc/thread-self by /proc/self to detect the memory usage.

Tests:
Passed core tests in CentOS.

Change-Id: I045e91aa9b7d8e1b731e3261f0f18cc932c16f43
---
M be/src/runtime/client-cache-test.cc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/18332/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I045e91aa9b7d8e1b731e3261f0f18cc932c16f43
Gerrit-Change-Number: 18332
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>