[GitHub] [dolphinscheduler] github-code-scanning[bot] commented on a diff in pull request #12722: [fix-12721]in the when edit task definition, resolve edit upstream task code always fail

[GitBox <gi...@apache.org>]

github-code-scanning[bot] commented on code in PR #12722:
URL: https://github.com/apache/dolphinscheduler/pull/12722#discussion_r1047108606


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java:
##########
@@ -884,6 +893,92 @@
         return result;
     }
 
+    private void updateUpstreamTask(Set<Long> allPreTaskCodeSet, long taskCode, long projectCode,
+                                    long processDefinitionCode, User loginUser) {
+        // query all process task relation
+        List<ProcessTaskRelation> hadProcessTaskRelationList = processTaskRelationMapper
+                .queryUpstreamByCode(projectCode, taskCode);
+        // remove pre
+        Set<Long> removePreTaskSet = new HashSet<>();

Review Comment:
   ## Container contents are never accessed
   
   The contents of this container are never accessed.
   
   [Show more details](https://github.com/apache/dolphinscheduler/security/code-scanning/2391)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org