You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Narayan Periwal <na...@inmobi.com> on 2015/09/22 08:07:47 UTC

Re: Review Request 33207: OOZIE:2243 - Hadoop jobs doesnot get killed when coordinator action get killed

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33207/
-----------------------------------------------------------

(Updated Sept. 22, 2015, 6:07 a.m.)


Review request for oozie.


Bugs: OOZIE-2243
    https://issues.apache.org/jira/browse/OOZIE-2243


Repository: oozie-git


Description
-------

Whenever the coord action or workflow gets killed only the job that has error gets killed while the other hadoop jobs keeps on running and only the workflow status gets changed to killed.


Diffs (updated)
-----

  core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java a6e7000 
  core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java e22329d 
  core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 85a6cd7 
  core/src/test/java/org/apache/oozie/command/wf/TestWorkflowKillXCommand.java e493d4d 
  hadooplibs/hadoop-utils-2/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java ce8c14f 

Diff: https://reviews.apache.org/r/33207/diff/


Testing
-------

Done


Thanks,

Narayan Periwal


Re: Review Request 33207: OOZIE:2243 - Hadoop jobs doesnot get killed when coordinator action get killed

Posted by Srikanth Sundarrajan <sr...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33207/#review100532
-----------------------------------------------------------



core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java (line 159)
<https://reviews.apache.org/r/33207/#comment157753>

    This seems like a util function access across classes. Can this be in an appropriate util class (LauncherMapperHelper) where the tag is originally formed ?



core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java (line 252)
<https://reviews.apache.org/r/33207/#comment157755>

    An important function is tucked in another statement. Avoid to help improve code readability.
    
    Would prefer that getActionYarnTag is in an independent statement assigned to a var and used subsequently.



hadooplibs/hadoop-utils-2/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java (line 59)
<https://reviews.apache.org/r/33207/#comment157756>

    Shouldn't this be the other way around. why are we prefering System::getProperty() over actionConf ?


- Srikanth Sundarrajan


On Sept. 22, 2015, 11:01 a.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33207/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 11:01 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-2243
>     https://issues.apache.org/jira/browse/OOZIE-2243
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> Whenever the coord action or workflow gets killed only the job that has error gets killed while the other hadoop jobs keeps on running and only the workflow status gets changed to killed.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java a6e7000 
>   core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java e22329d 
>   core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 85a6cd7 
>   core/src/test/java/org/apache/oozie/command/wf/TestWorkflowKillXCommand.java e493d4d 
>   hadooplibs/hadoop-utils-2/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java ce8c14f 
> 
> Diff: https://reviews.apache.org/r/33207/diff/
> 
> 
> Testing
> -------
> 
> Done
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>


Re: Review Request 33207: OOZIE:2243 - Hadoop jobs doesnot get killed when coordinator action get killed

Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33207/#review103390
-----------------------------------------------------------


Code is good. Testcase needs to be rewritten.


core/src/test/java/org/apache/oozie/command/wf/TestWorkflowKillXCommand.java (line 134)
<https://reviews.apache.org/r/33207/#comment161448>

    This testcase does not actually test killing of child job. It just creates workflow job and action entries in database and there are no mapreduce jobs (launcher or child) running. Calling kill will just make the job and action marked killed.
    
    You need a test like TestJavaActionExecutor.testKill(). Difference is you need to write a action that launches a child job and then assert if both the java action and child job are killed. Pig script with a Jython UDF (don't have to write java UDF) that does sleep for a long time is a easy one. And you will have to skip the test for Hadoop 1.x . i.e
    
    org.junit.Assume.assumeTrue("Skip this test for Hadoop 1.x", HadoopShims.isYARN());


- Rohini Palaniswamy


On Sept. 29, 2015, 11:46 a.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33207/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2015, 11:46 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-2243
>     https://issues.apache.org/jira/browse/OOZIE-2243
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> Whenever the coord action or workflow gets killed only the job that has error gets killed while the other hadoop jobs keeps on running and only the workflow status gets changed to killed.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java a6e7000 
>   core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java e22329d 
>   core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621 
>   core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 85a6cd7 
>   core/src/test/java/org/apache/oozie/command/wf/TestWorkflowKillXCommand.java e493d4d 
>   hadooplibs/hadoop-utils-2/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java ce8c14f 
>   hadooplibs/hadoop-utils-3/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java 94e01ea 
> 
> Diff: https://reviews.apache.org/r/33207/diff/
> 
> 
> Testing
> -------
> 
> Done
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>


Re: Review Request 33207: OOZIE:2243 - Hadoop jobs doesnot get killed when coordinator action get killed

Posted by Narayan Periwal <na...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33207/
-----------------------------------------------------------

(Updated Sept. 29, 2015, 11:46 a.m.)


Review request for oozie.


Bugs: OOZIE-2243
    https://issues.apache.org/jira/browse/OOZIE-2243


Repository: oozie-git


Description
-------

Whenever the coord action or workflow gets killed only the job that has error gets killed while the other hadoop jobs keeps on running and only the workflow status gets changed to killed.


Diffs (updated)
-----

  core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java a6e7000 
  core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java e22329d 
  core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621 
  core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 85a6cd7 
  core/src/test/java/org/apache/oozie/command/wf/TestWorkflowKillXCommand.java e493d4d 
  hadooplibs/hadoop-utils-2/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java ce8c14f 
  hadooplibs/hadoop-utils-3/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java 94e01ea 

Diff: https://reviews.apache.org/r/33207/diff/


Testing
-------

Done


Thanks,

Narayan Periwal


Re: Review Request 33207: OOZIE:2243 - Hadoop jobs doesnot get killed when coordinator action get killed

Posted by Narayan Periwal <na...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33207/
-----------------------------------------------------------

(Updated Sept. 22, 2015, 11:01 a.m.)


Review request for oozie.


Bugs: OOZIE-2243
    https://issues.apache.org/jira/browse/OOZIE-2243


Repository: oozie-git


Description
-------

Whenever the coord action or workflow gets killed only the job that has error gets killed while the other hadoop jobs keeps on running and only the workflow status gets changed to killed.


Diffs (updated)
-----

  core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java a6e7000 
  core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java e22329d 
  core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 85a6cd7 
  core/src/test/java/org/apache/oozie/command/wf/TestWorkflowKillXCommand.java e493d4d 
  hadooplibs/hadoop-utils-2/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java ce8c14f 

Diff: https://reviews.apache.org/r/33207/diff/


Testing
-------

Done


Thanks,

Narayan Periwal