You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by fgiorgetti <gi...@git.apache.org> on 2018/06/12 20:36:30 UTC
[GitHub] qpid-dispatch pull request #323: DISPATCH-976 - Commenting last assert which...
GitHub user fgiorgetti opened a pull request:
https://github.com/apache/qpid-dispatch/pull/323
DISPATCH-976 - Commenting last assert which is causing router to crash
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fgiorgetti/qpid-dispatch fgiorgetti-DISPATCH-976-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/323.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #323
----
commit fd7eda39c245b57596841222c5db1d7c8581c86f
Author: Fernando Giorgetti <fg...@...>
Date: 2018-06-12T20:35:33Z
DISPATCH-976 - Commenting last assert which is causing router to crash
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #323: DISPATCH-976 - Commenting last assert which...
Posted by fgiorgetti <gi...@git.apache.org>.
Github user fgiorgetti closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/323
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch issue #323: DISPATCH-976 - Commenting last assert which is cau...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/qpid-dispatch/pull/323
# [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/323?src=pr&el=h1) Report
> Merging [#323](https://codecov.io/gh/apache/qpid-dispatch/pull/323?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/8c7e87275fb481f25d8deaa4f639f3a4d1c532d9?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/323/graphs/tree.svg?token=rk2Cgd27pP&width=650&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/323?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #323 +/- ##
==========================================
+ Coverage 86.55% 86.58% +0.03%
==========================================
Files 69 69
Lines 15466 15465 -1
==========================================
+ Hits 13387 13391 +4
+ Misses 2079 2074 -5
```
| [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/323?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/policy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/323/diff?src=pr&el=tree#diff-c3JjL3BvbGljeS5j) | `86.95% <ø> (+1.06%)` | :arrow_up: |
| [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/323/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `63.21% <0%> (-0.58%)` | :arrow_down: |
| [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/323/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `94.57% <0%> (-0.15%)` | :arrow_down: |
| [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/323/diff?src=pr&el=tree#diff-c3JjL3NlcnZlci5j) | `87.73% <0%> (-0.12%)` | :arrow_down: |
| [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/323/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `86.8% <0%> (+0.19%)` | :arrow_up: |
| [src/remote\_sasl.c](https://codecov.io/gh/apache/qpid-dispatch/pull/323/diff?src=pr&el=tree#diff-c3JjL3JlbW90ZV9zYXNsLmM=) | `83.03% <0%> (+0.3%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/323?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/323?src=pr&el=footer). Last update [8c7e872...fd7eda3](https://codecov.io/gh/apache/qpid-dispatch/pull/323?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch issue #323: DISPATCH-976 - Commenting last assert which is cau...
Posted by fgiorgetti <gi...@git.apache.org>.
Github user fgiorgetti commented on the issue:
https://github.com/apache/qpid-dispatch/pull/323
I believe I found the reason for the failure. I will provide a new PR and ask Chuck to review it.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org