You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2018/06/05 06:07:01 UTC
[Impala-ASF-CR](2.x) IMPALA-6947: Kudu tests flaky due to rpc timeout
Hello Michael Ho, Michael Brown, Impala Public Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10603
to review the following change.
Change subject: IMPALA-6947: Kudu tests flaky due to rpc timeout
......................................................................
IMPALA-6947: Kudu tests flaky due to rpc timeout
Some Kudu tests occasionally fail due to hitting an rpc timeout when
running on a heavily loaded machine. For normal operation, having a
low timeout is good for noticing issues quickly, but for tests there's
no real reason we can't set this higher to avoid flakiness.
This patch adds a flag, -kudu_client_rpc_timeout_ms, disabled by
default. It also sets -kudu_client_rpc_timeout_ms to 60s for ASAN in
start-impala-cluster.py, higher than Kudu's default value of 10s.
Testing:
- Passed a full run of core tests on ASAN.
Change-Id: I8c4a2d87934cd4eb98509512f7060a596894ed53
Reviewed-on: http://gerrit.cloudera.org:8080/10466
Reviewed-by: Michael Brown <mi...@cloudera.com>
Reviewed-by: Michael Ho <kw...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/common/global-flags.cc
M be/src/exec/kudu-util.cc
M bin/start-impala-cluster.py
3 files changed, 19 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/10603/1
--
To view, visit http://gerrit.cloudera.org:8080/10603
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8c4a2d87934cd4eb98509512f7060a596894ed53
Gerrit-Change-Number: 10603
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
[Impala-ASF-CR](2.x) IMPALA-6947: Kudu tests flaky due to rpc timeout
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10603 )
Change subject: IMPALA-6947: Kudu tests flaky due to rpc timeout
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10603
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c4a2d87934cd4eb98509512f7060a596894ed53
Gerrit-Change-Number: 10603
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Tue, 05 Jun 2018 09:51:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6947: Kudu tests flaky due to rpc timeout
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10603 )
Change subject: IMPALA-6947: Kudu tests flaky due to rpc timeout
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2592/
--
To view, visit http://gerrit.cloudera.org:8080/10603
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c4a2d87934cd4eb98509512f7060a596894ed53
Gerrit-Change-Number: 10603
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Tue, 05 Jun 2018 06:07:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6947: Kudu tests flaky due to rpc timeout
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10603 )
Change subject: IMPALA-6947: Kudu tests flaky due to rpc timeout
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10603
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c4a2d87934cd4eb98509512f7060a596894ed53
Gerrit-Change-Number: 10603
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Tue, 05 Jun 2018 15:15:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6947: Kudu tests flaky due to rpc timeout
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10603 )
Change subject: IMPALA-6947: Kudu tests flaky due to rpc timeout
......................................................................
IMPALA-6947: Kudu tests flaky due to rpc timeout
Some Kudu tests occasionally fail due to hitting an rpc timeout when
running on a heavily loaded machine. For normal operation, having a
low timeout is good for noticing issues quickly, but for tests there's
no real reason we can't set this higher to avoid flakiness.
This patch adds a flag, -kudu_client_rpc_timeout_ms, disabled by
default. It also sets -kudu_client_rpc_timeout_ms to 60s for ASAN in
start-impala-cluster.py, higher than Kudu's default value of 10s.
Testing:
- Passed a full run of core tests on ASAN.
Change-Id: I8c4a2d87934cd4eb98509512f7060a596894ed53
Reviewed-on: http://gerrit.cloudera.org:8080/10466
Reviewed-by: Michael Brown <mi...@cloudera.com>
Reviewed-by: Michael Ho <kw...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-on: http://gerrit.cloudera.org:8080/10603
---
M be/src/common/global-flags.cc
M be/src/exec/kudu-util.cc
M bin/start-impala-cluster.py
3 files changed, 19 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Verified
Michael Brown: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/10603
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c4a2d87934cd4eb98509512f7060a596894ed53
Gerrit-Change-Number: 10603
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>