You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2022/10/06 00:46:04 UTC
[commons-csv] branch master updated: Use Java 8 API
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-csv.git
The following commit(s) were added to refs/heads/master by this push:
new af42c835 Use Java 8 API
af42c835 is described below
commit af42c835b5689b52764d34a205a324f09da50aac
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Wed Oct 5 20:45:59 2022 -0400
Use Java 8 API
---
src/main/java/org/apache/commons/csv/CSVFormat.java | 8 ++------
src/test/java/org/apache/commons/csv/issues/JiraCsv288Test.java | 1 +
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/src/main/java/org/apache/commons/csv/CSVFormat.java b/src/main/java/org/apache/commons/csv/CSVFormat.java
index ba39b742..2d44c11b 100644
--- a/src/main/java/org/apache/commons/csv/CSVFormat.java
+++ b/src/main/java/org/apache/commons/csv/CSVFormat.java
@@ -414,9 +414,7 @@ public final class CSVFormat implements Serializable {
if (headerEnum != null) {
final Enum<?>[] enumValues = headerEnum.getEnumConstants();
header = new String[enumValues.length];
- for (int i = 0; i < enumValues.length; i++) {
- header[i] = enumValues[i].name();
- }
+ Arrays.setAll(header, i -> enumValues[i].name());
}
return setHeader(header);
}
@@ -1243,9 +1241,7 @@ public final class CSVFormat implements Serializable {
return null;
}
final String[] strings = new String[values.length];
- for (int i = 0; i < values.length; i++) {
- strings[i] = Objects.toString(values[i], null);
- }
+ Arrays.setAll(strings, i -> Objects.toString(values[i], null));
return strings;
}
diff --git a/src/test/java/org/apache/commons/csv/issues/JiraCsv288Test.java b/src/test/java/org/apache/commons/csv/issues/JiraCsv288Test.java
index 920dcb73..3ea6c1eb 100644
--- a/src/test/java/org/apache/commons/csv/issues/JiraCsv288Test.java
+++ b/src/test/java/org/apache/commons/csv/issues/JiraCsv288Test.java
@@ -29,6 +29,7 @@ import org.apache.commons.csv.CSVRecord;
import org.junit.jupiter.api.Test;
public class JiraCsv288Test {
+
@Test
// Before fix:
// expected: <a,b,c,d,,f> but was: <a,b,c,d,|f>