You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org> on 2013/10/21 17:47:42 UTC

[jira] [Reopened] (MYFACES-3780) _ComponentAttributesMap return null when no property descriptor is available and null value is passed to map

     [ https://issues.apache.org/jira/browse/MYFACES-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leonardo Uribe reopened MYFACES-3780:
-------------------------------------


Found compatibility test that fails if this patch is applied, reverting fix and closing it as invalid.

> _ComponentAttributesMap return null when no property descriptor is available and null value is passed to map
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-3780
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3780
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-314, JSR-344
>            Reporter: Leonardo Uribe
>            Assignee: Leonardo Uribe
>             Fix For: 2.0.19, 2.1.13, 2.2.0-beta
>
>
> Checking some stuff I have found that there is an old check for null in ComponentAttributesMap.put(...)
> This check doesn't have sense, because null values are valid for hashmap, and in that sense the check is useless.
> The fix is very simple, just remove the unnecessary check. I just comment the related code, to prevent other people to try to add it in the future.
> The fix will be done on 2.0.x, 2.1.x and 2.2.x branches



--
This message was sent by Atlassian JIRA
(v6.1#6144)