You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Branko Čibej <br...@apache.org> on 2015/09/17 13:14:17 UTC

Re: svn commit: r1703470 - /subversion/trunk/INSTALL

On 17.09.2015 01:21, luke1410@apache.org wrote:
> Author: luke1410
> Date: Wed Sep 16 23:21:11 2015
> New Revision: 1703470
>
> URL: http://svn.apache.org/r1703470
> Log:
> Remove obsolete (since at least 1.7) step to run gen-make before building
> Apache httpd for Windows.
>
> * INSTALL
>   documentation updated


Stefan, please read the log message guidelines at

http://subversion.apache.org/docs/community-guide/conventions.html#log-messages

again. Your last 8 commits all contain that incorrectly formatted part
that refers to the INSTALL file. This is a minor nit, but we're all so
used to the formatting that the slight typo sort of pops out.

-- Brane

Re: svn commit: r1703470 - /subversion/trunk/INSTALL

Posted by Stefan <lu...@posteo.de>.
On 17/09/2015 13:14, Branko Čibej wrote:
> On 17.09.2015 01:21, luke1410@apache.org wrote:
>> Author: luke1410
>> Date: Wed Sep 16 23:21:11 2015
>> New Revision: 1703470
>>
>> URL: http://svn.apache.org/r1703470
>> Log:
>> Remove obsolete (since at least 1.7) step to run gen-make before building
>> Apache httpd for Windows.
>>
>> * INSTALL
>>    documentation updated
>
> Stefan, please read the log message guidelines at
>
> http://subversion.apache.org/docs/community-guide/conventions.html#log-messages
>
> again. Your last 8 commits all contain that incorrectly formatted part
> that refers to the INSTALL file. This is a minor nit, but we're all so
> used to the formatting that the slight typo sort of pops out.
>
> -- Brane
Thanks for reviewing the commits and the log messages. I've just updated 
them to better fit with the standard.

I wasn't too sure about the "Following on xxxx" styles, since I couldn't 
find a fully matching example but rather followed the style of existing 
logs on trunk.
Please let me know if theres further things which should be changed and 
if the style for the "Following up" logs is correct, I'd offer to add 
such an example to the community-guide, if that's wanted.

Regards,
Stefan