[jira] [Commented] (AVRO-3532) Align naming rules on code

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-3532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628770#comment-17628770 ] 

ASF subversion and git services commented on AVRO-3532:
-------------------------------------------------------

Commit 965e0a2df8c94657e333ca166515e2dba70ca400 in avro's branch refs/heads/master from clesaec
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=965e0a2df ]

AVRO-3532: Test field names in C# (#1866)



> Align naming rules on code
> --------------------------
>
>                 Key: AVRO-3532
>                 URL: https://issues.apache.org/jira/browse/AVRO-3532
>             Project: Apache Avro
>          Issue Type: Wish
>            Reporter: Christophe Le Saec
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Description of [naming rule on documentation|https://avro.apache.org/docs/1.11.1/specification/#names] is
> {noformat}
>     - start with [A-Za-z_]
>     - subsequently contain only [A-Za-z0-9_]
> {noformat}
> But [java code|https://github.com/apache/avro/blob/master/lang/java/avro/src/main/java/org/apache/avro/Schema.java#L1578] use Character.isLetter method
> {code:java}
>     char first = name.charAt(0);
>     if (!(Character.isLetter(first) || first == '_'))
>       throw new SchemaParseException("Illegal initial character: " + name);
>     for (int i = 1; i < length; i++) {
>       char c = name.charAt(i);
>       if (!(Character.isLetterOrDigit(c) || c == '_'))
>         throw new SchemaParseException("Illegal character in: " + name);
>     }
>     return name;
> {code}
> This method accept accent éùàçË ... and also chinese character (我) ...
> Object of this JIRA is to update names rules in documentation to include what java already accept.
> C# also accept this kind of name ([See this PR|https://github.com/apache/avro/pull/1866])
> Rust & C need updates (others PR)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)