You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Dmitry Pavlov <dp...@gmail.com> on 2017/05/17 17:46:33 UTC
Ignite 2.0 TeamCity Run configurations
Hi, Igniters!
Alex (al.psc) has created new Teamcity run configurations optimized for
running 2.0 version and later. This project and its run configurations
avoid duplicate tests running for binary and default marshallers because it
is now the same for 2.0+.
Usage of this run configuration saves us at least 12 machine-hours for each
test run and in future will allow us to get test results faster.
Do you have concerns or remarks about using new run configurations for all
2.0+ pull requests?
We are now doing final checks of compatibility of these run configurations
with code. Any ideas about what is to be migrated are appreciated.
Best Regards,
Dmitry Pavlov
Re: Ignite 2.0 TeamCity Run configurations
Posted by Dmitry Pavlov <dp...@gmail.com>.
Igniters,
I've found one more suite without tests: "Ignite Cache Failover Multi JVM"
(org.apache.ignite.testsuites.IgniteCacheFailoverMJTestSuite). Currently
has paused triggers, but anyway started from Ignite 2.0 snapshot
dependecies.
Is it required? Alex (al.psc) do you know? it is required in 2.0 run
configs?
Sincerely,
Dmitriy Pavlov
пт, 26 мая 2017 г. в 14:57, Dmitry Pavlov <dp...@gmail.com>:
> Thank you!
>
> I've commited removal of both suites to PR
> https://github.com/apache/ignite/pull/2014
>
>
> пт, 26 мая 2017 г. в 14:53, Vladimir Ozerov <vo...@gridgain.com>:
>
>> No, we should remote this suite.
>>
>> On Fri, May 26, 2017 at 2:48 PM, Semyon Boikov <sb...@gridgain.com>
>> wrote:
>>
>> > What about 'Ignite H2 Indexing' suite', it does not execute any test?
>> >
>> > On Fri, May 26, 2017 at 2:18 PM, Dmitry Pavlov <dp...@gmail.com>
>> > wrote:
>> >
>> > > Hi Semen,
>> > >
>> > >
>> > >
>> > > Thank you for this fix. It is correct to replace to
>> IgniteCacheTestSuite4
>> > > in new 2.0 run configurations as we don’t have Binary* analogue.
>> > >
>> > >
>> > >
>> > > IgniteBinaryBasicTestSuite was not deleted to avoid failures in old
>> run
>> > > configurations. I assumed missing test suite will cause failure on
>> > > teamcity. But the first issue shows us it is not a problem. I’ll
>> prepare
>> > PR
>> > > for removing suite.
>> > >
>> > >
>> > >
>> > > IgniteBinaryObjectsCacheTestSuite3 is kept together with
>> > > IgniteCacheTestSuite3 for backward compatibility. In Ignite 2.0 tests
>> > first
>> > > is used, and in Ignite tests - second. And if someone runs old run
>> > configs
>> > > then most test will be executed anyway. Practice shows not everyone in
>> > > community uses new Run Configs for master-based PRs. In future we
>> will be
>> > > able to remove not necessary suite.
>> > >
>> > >
>> > > Sincerely,
>> > >
>> > > Dmitriy Pavlov
>> > >
>> > >
>> > >
>> > > пт, 26 мая 2017 г. в 14:00, Semyon Boikov <sb...@gridgain.com>:
>> > >
>> > > > I just found that 'Ignite Cache 4' was not executed on TeamCity
>> since
>> > it
>> > > > has from suite name in configuration, I fixed it to use
>> > > > IgniteCacheTestSuite4, is it correct?
>> > > >
>> > > > Aslo why we need both IgniteBinaryObjectsCacheTestSuite3 and
>> > > > IgniteCacheTestSuite3? And why IgniteBinaryBasicTestSuite is not
>> > deleted?
>> > > >
>> > > > Thanks
>> > > >
>> > > > On Mon, May 22, 2017 at 6:39 PM, Dmitry Pavlov <
>> dpavlov.spb@gmail.com>
>> > > > wrote:
>> > > >
>> > > > > Igniters,
>> > > > >
>> > > > > I've created new PR https://github.com/apache/ignite/pull/1986
>> > without
>> > > > > merge conflicts against master. Please review these changes
>> instead
>> > of
>> > > > > PR1956.
>> > > > >
>> > > > > Thank you
>> > > > >
>> > > > > Best Regards,
>> > > > > Dmitry Pavlov
>> > > > >
>> > > > > пн, 22 мая 2017 г. в 13:21, Alexey Goncharuk <
>> > > alexey.goncharuk@gmail.com
>> > > > >:
>> > > > >
>> > > > > > Thanks, Dmitriy!
>> > > > > >
>> > > > > > If there are no other objections, I will merge the changes
>> shortly.
>> > > > > >
>> > > > > > 2017-05-22 13:10 GMT+03:00 Dmitry Pavlov <dpavlov.spb@gmail.com
>> >:
>> > > > > >
>> > > > > > > Hi, Igniters!
>> > > > > > >
>> > > > > > > Could you please review and merge changes from
>> > > > > > > https://github.com/apache/ignite/pull/1956 into master.
>> > > > > > >
>> > > > > > > These changes makes running tests with similar results in TC
>> Run
>> > > > > configs
>> > > > > > > "Ignite 2.0 Tests" as it is in "Ignite Tests".
>> > > > > > >
>> > > > > > > Best regards,
>> > > > > > > Dmitry Pavlov
>> > > > > > >
>> > > > > > > ср, 17 мая 2017 г. в 20:52, Alexey Goncharuk <
>> > > > > alexey.goncharuk@gmail.com
>> > > > > > >:
>> > > > > > >
>> > > > > > > > Great news! Looking forward to getting rid of the
>> unnecessary
>> > TC
>> > > > > > > > configurations.
>> > > > > > > >
>> > > > > > > > Once this is done, I think we should also work out if we can
>> > use
>> > > > > build
>> > > > > > > > once, run tests approach for RunAll configuration. Does
>> anybody
>> > > > have
>> > > > > a
>> > > > > > > clue
>> > > > > > > > if this is possible?
>> > > > > > > >
>> > > > > > > > 2017-05-17 20:46 GMT+03:00 Dmitry Pavlov <
>> > dpavlov.spb@gmail.com
>> > > >:
>> > > > > > > >
>> > > > > > > > > Hi, Igniters!
>> > > > > > > > >
>> > > > > > > > > Alex (al.psc) has created new Teamcity run configurations
>> > > > optimized
>> > > > > > for
>> > > > > > > > > running 2.0 version and later. This project and its run
>> > > > > > configurations
>> > > > > > > > > avoid duplicate tests running for binary and default
>> > > marshallers
>> > > > > > > because
>> > > > > > > > it
>> > > > > > > > > is now the same for 2.0+.
>> > > > > > > > >
>> > > > > > > > > Usage of this run configuration saves us at least 12
>> > > > machine-hours
>> > > > > > for
>> > > > > > > > each
>> > > > > > > > > test run and in future will allow us to get test results
>> > > faster.
>> > > > > > > > >
>> > > > > > > > > Do you have concerns or remarks about using new run
>> > > > configurations
>> > > > > > for
>> > > > > > > > all
>> > > > > > > > > 2.0+ pull requests?
>> > > > > > > > >
>> > > > > > > > > We are now doing final checks of compatibility of these
>> run
>> > > > > > > > configurations
>> > > > > > > > > with code. Any ideas about what is to be migrated are
>> > > > appreciated.
>> > > > > > > > >
>> > > > > > > > > Best Regards,
>> > > > > > > > > Dmitry Pavlov
>> > > > > > > > >
>> > > > > > > >
>> > > > > > >
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>>
>
Re: Ignite 2.0 TeamCity Run configurations
Posted by Dmitry Pavlov <dp...@gmail.com>.
Thank you!
I've commited removal of both suites to PR
https://github.com/apache/ignite/pull/2014
пт, 26 мая 2017 г. в 14:53, Vladimir Ozerov <vo...@gridgain.com>:
> No, we should remote this suite.
>
> On Fri, May 26, 2017 at 2:48 PM, Semyon Boikov <sb...@gridgain.com>
> wrote:
>
> > What about 'Ignite H2 Indexing' suite', it does not execute any test?
> >
> > On Fri, May 26, 2017 at 2:18 PM, Dmitry Pavlov <dp...@gmail.com>
> > wrote:
> >
> > > Hi Semen,
> > >
> > >
> > >
> > > Thank you for this fix. It is correct to replace to
> IgniteCacheTestSuite4
> > > in new 2.0 run configurations as we don’t have Binary* analogue.
> > >
> > >
> > >
> > > IgniteBinaryBasicTestSuite was not deleted to avoid failures in old run
> > > configurations. I assumed missing test suite will cause failure on
> > > teamcity. But the first issue shows us it is not a problem. I’ll
> prepare
> > PR
> > > for removing suite.
> > >
> > >
> > >
> > > IgniteBinaryObjectsCacheTestSuite3 is kept together with
> > > IgniteCacheTestSuite3 for backward compatibility. In Ignite 2.0 tests
> > first
> > > is used, and in Ignite tests - second. And if someone runs old run
> > configs
> > > then most test will be executed anyway. Practice shows not everyone in
> > > community uses new Run Configs for master-based PRs. In future we will
> be
> > > able to remove not necessary suite.
> > >
> > >
> > > Sincerely,
> > >
> > > Dmitriy Pavlov
> > >
> > >
> > >
> > > пт, 26 мая 2017 г. в 14:00, Semyon Boikov <sb...@gridgain.com>:
> > >
> > > > I just found that 'Ignite Cache 4' was not executed on TeamCity since
> > it
> > > > has from suite name in configuration, I fixed it to use
> > > > IgniteCacheTestSuite4, is it correct?
> > > >
> > > > Aslo why we need both IgniteBinaryObjectsCacheTestSuite3 and
> > > > IgniteCacheTestSuite3? And why IgniteBinaryBasicTestSuite is not
> > deleted?
> > > >
> > > > Thanks
> > > >
> > > > On Mon, May 22, 2017 at 6:39 PM, Dmitry Pavlov <
> dpavlov.spb@gmail.com>
> > > > wrote:
> > > >
> > > > > Igniters,
> > > > >
> > > > > I've created new PR https://github.com/apache/ignite/pull/1986
> > without
> > > > > merge conflicts against master. Please review these changes instead
> > of
> > > > > PR1956.
> > > > >
> > > > > Thank you
> > > > >
> > > > > Best Regards,
> > > > > Dmitry Pavlov
> > > > >
> > > > > пн, 22 мая 2017 г. в 13:21, Alexey Goncharuk <
> > > alexey.goncharuk@gmail.com
> > > > >:
> > > > >
> > > > > > Thanks, Dmitriy!
> > > > > >
> > > > > > If there are no other objections, I will merge the changes
> shortly.
> > > > > >
> > > > > > 2017-05-22 13:10 GMT+03:00 Dmitry Pavlov <dpavlov.spb@gmail.com
> >:
> > > > > >
> > > > > > > Hi, Igniters!
> > > > > > >
> > > > > > > Could you please review and merge changes from
> > > > > > > https://github.com/apache/ignite/pull/1956 into master.
> > > > > > >
> > > > > > > These changes makes running tests with similar results in TC
> Run
> > > > > configs
> > > > > > > "Ignite 2.0 Tests" as it is in "Ignite Tests".
> > > > > > >
> > > > > > > Best regards,
> > > > > > > Dmitry Pavlov
> > > > > > >
> > > > > > > ср, 17 мая 2017 г. в 20:52, Alexey Goncharuk <
> > > > > alexey.goncharuk@gmail.com
> > > > > > >:
> > > > > > >
> > > > > > > > Great news! Looking forward to getting rid of the unnecessary
> > TC
> > > > > > > > configurations.
> > > > > > > >
> > > > > > > > Once this is done, I think we should also work out if we can
> > use
> > > > > build
> > > > > > > > once, run tests approach for RunAll configuration. Does
> anybody
> > > > have
> > > > > a
> > > > > > > clue
> > > > > > > > if this is possible?
> > > > > > > >
> > > > > > > > 2017-05-17 20:46 GMT+03:00 Dmitry Pavlov <
> > dpavlov.spb@gmail.com
> > > >:
> > > > > > > >
> > > > > > > > > Hi, Igniters!
> > > > > > > > >
> > > > > > > > > Alex (al.psc) has created new Teamcity run configurations
> > > > optimized
> > > > > > for
> > > > > > > > > running 2.0 version and later. This project and its run
> > > > > > configurations
> > > > > > > > > avoid duplicate tests running for binary and default
> > > marshallers
> > > > > > > because
> > > > > > > > it
> > > > > > > > > is now the same for 2.0+.
> > > > > > > > >
> > > > > > > > > Usage of this run configuration saves us at least 12
> > > > machine-hours
> > > > > > for
> > > > > > > > each
> > > > > > > > > test run and in future will allow us to get test results
> > > faster.
> > > > > > > > >
> > > > > > > > > Do you have concerns or remarks about using new run
> > > > configurations
> > > > > > for
> > > > > > > > all
> > > > > > > > > 2.0+ pull requests?
> > > > > > > > >
> > > > > > > > > We are now doing final checks of compatibility of these run
> > > > > > > > configurations
> > > > > > > > > with code. Any ideas about what is to be migrated are
> > > > appreciated.
> > > > > > > > >
> > > > > > > > > Best Regards,
> > > > > > > > > Dmitry Pavlov
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: Ignite 2.0 TeamCity Run configurations
Posted by Vladimir Ozerov <vo...@gridgain.com>.
No, we should remote this suite.
On Fri, May 26, 2017 at 2:48 PM, Semyon Boikov <sb...@gridgain.com> wrote:
> What about 'Ignite H2 Indexing' suite', it does not execute any test?
>
> On Fri, May 26, 2017 at 2:18 PM, Dmitry Pavlov <dp...@gmail.com>
> wrote:
>
> > Hi Semen,
> >
> >
> >
> > Thank you for this fix. It is correct to replace to IgniteCacheTestSuite4
> > in new 2.0 run configurations as we don’t have Binary* analogue.
> >
> >
> >
> > IgniteBinaryBasicTestSuite was not deleted to avoid failures in old run
> > configurations. I assumed missing test suite will cause failure on
> > teamcity. But the first issue shows us it is not a problem. I’ll prepare
> PR
> > for removing suite.
> >
> >
> >
> > IgniteBinaryObjectsCacheTestSuite3 is kept together with
> > IgniteCacheTestSuite3 for backward compatibility. In Ignite 2.0 tests
> first
> > is used, and in Ignite tests - second. And if someone runs old run
> configs
> > then most test will be executed anyway. Practice shows not everyone in
> > community uses new Run Configs for master-based PRs. In future we will be
> > able to remove not necessary suite.
> >
> >
> > Sincerely,
> >
> > Dmitriy Pavlov
> >
> >
> >
> > пт, 26 мая 2017 г. в 14:00, Semyon Boikov <sb...@gridgain.com>:
> >
> > > I just found that 'Ignite Cache 4' was not executed on TeamCity since
> it
> > > has from suite name in configuration, I fixed it to use
> > > IgniteCacheTestSuite4, is it correct?
> > >
> > > Aslo why we need both IgniteBinaryObjectsCacheTestSuite3 and
> > > IgniteCacheTestSuite3? And why IgniteBinaryBasicTestSuite is not
> deleted?
> > >
> > > Thanks
> > >
> > > On Mon, May 22, 2017 at 6:39 PM, Dmitry Pavlov <dp...@gmail.com>
> > > wrote:
> > >
> > > > Igniters,
> > > >
> > > > I've created new PR https://github.com/apache/ignite/pull/1986
> without
> > > > merge conflicts against master. Please review these changes instead
> of
> > > > PR1956.
> > > >
> > > > Thank you
> > > >
> > > > Best Regards,
> > > > Dmitry Pavlov
> > > >
> > > > пн, 22 мая 2017 г. в 13:21, Alexey Goncharuk <
> > alexey.goncharuk@gmail.com
> > > >:
> > > >
> > > > > Thanks, Dmitriy!
> > > > >
> > > > > If there are no other objections, I will merge the changes shortly.
> > > > >
> > > > > 2017-05-22 13:10 GMT+03:00 Dmitry Pavlov <dp...@gmail.com>:
> > > > >
> > > > > > Hi, Igniters!
> > > > > >
> > > > > > Could you please review and merge changes from
> > > > > > https://github.com/apache/ignite/pull/1956 into master.
> > > > > >
> > > > > > These changes makes running tests with similar results in TC Run
> > > > configs
> > > > > > "Ignite 2.0 Tests" as it is in "Ignite Tests".
> > > > > >
> > > > > > Best regards,
> > > > > > Dmitry Pavlov
> > > > > >
> > > > > > ср, 17 мая 2017 г. в 20:52, Alexey Goncharuk <
> > > > alexey.goncharuk@gmail.com
> > > > > >:
> > > > > >
> > > > > > > Great news! Looking forward to getting rid of the unnecessary
> TC
> > > > > > > configurations.
> > > > > > >
> > > > > > > Once this is done, I think we should also work out if we can
> use
> > > > build
> > > > > > > once, run tests approach for RunAll configuration. Does anybody
> > > have
> > > > a
> > > > > > clue
> > > > > > > if this is possible?
> > > > > > >
> > > > > > > 2017-05-17 20:46 GMT+03:00 Dmitry Pavlov <
> dpavlov.spb@gmail.com
> > >:
> > > > > > >
> > > > > > > > Hi, Igniters!
> > > > > > > >
> > > > > > > > Alex (al.psc) has created new Teamcity run configurations
> > > optimized
> > > > > for
> > > > > > > > running 2.0 version and later. This project and its run
> > > > > configurations
> > > > > > > > avoid duplicate tests running for binary and default
> > marshallers
> > > > > > because
> > > > > > > it
> > > > > > > > is now the same for 2.0+.
> > > > > > > >
> > > > > > > > Usage of this run configuration saves us at least 12
> > > machine-hours
> > > > > for
> > > > > > > each
> > > > > > > > test run and in future will allow us to get test results
> > faster.
> > > > > > > >
> > > > > > > > Do you have concerns or remarks about using new run
> > > configurations
> > > > > for
> > > > > > > all
> > > > > > > > 2.0+ pull requests?
> > > > > > > >
> > > > > > > > We are now doing final checks of compatibility of these run
> > > > > > > configurations
> > > > > > > > with code. Any ideas about what is to be migrated are
> > > appreciated.
> > > > > > > >
> > > > > > > > Best Regards,
> > > > > > > > Dmitry Pavlov
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: Ignite 2.0 TeamCity Run configurations
Posted by Semyon Boikov <sb...@gridgain.com>.
What about 'Ignite H2 Indexing' suite', it does not execute any test?
On Fri, May 26, 2017 at 2:18 PM, Dmitry Pavlov <dp...@gmail.com>
wrote:
> Hi Semen,
>
>
>
> Thank you for this fix. It is correct to replace to IgniteCacheTestSuite4
> in new 2.0 run configurations as we don’t have Binary* analogue.
>
>
>
> IgniteBinaryBasicTestSuite was not deleted to avoid failures in old run
> configurations. I assumed missing test suite will cause failure on
> teamcity. But the first issue shows us it is not a problem. I’ll prepare PR
> for removing suite.
>
>
>
> IgniteBinaryObjectsCacheTestSuite3 is kept together with
> IgniteCacheTestSuite3 for backward compatibility. In Ignite 2.0 tests first
> is used, and in Ignite tests - second. And if someone runs old run configs
> then most test will be executed anyway. Practice shows not everyone in
> community uses new Run Configs for master-based PRs. In future we will be
> able to remove not necessary suite.
>
>
> Sincerely,
>
> Dmitriy Pavlov
>
>
>
> пт, 26 мая 2017 г. в 14:00, Semyon Boikov <sb...@gridgain.com>:
>
> > I just found that 'Ignite Cache 4' was not executed on TeamCity since it
> > has from suite name in configuration, I fixed it to use
> > IgniteCacheTestSuite4, is it correct?
> >
> > Aslo why we need both IgniteBinaryObjectsCacheTestSuite3 and
> > IgniteCacheTestSuite3? And why IgniteBinaryBasicTestSuite is not deleted?
> >
> > Thanks
> >
> > On Mon, May 22, 2017 at 6:39 PM, Dmitry Pavlov <dp...@gmail.com>
> > wrote:
> >
> > > Igniters,
> > >
> > > I've created new PR https://github.com/apache/ignite/pull/1986 without
> > > merge conflicts against master. Please review these changes instead of
> > > PR1956.
> > >
> > > Thank you
> > >
> > > Best Regards,
> > > Dmitry Pavlov
> > >
> > > пн, 22 мая 2017 г. в 13:21, Alexey Goncharuk <
> alexey.goncharuk@gmail.com
> > >:
> > >
> > > > Thanks, Dmitriy!
> > > >
> > > > If there are no other objections, I will merge the changes shortly.
> > > >
> > > > 2017-05-22 13:10 GMT+03:00 Dmitry Pavlov <dp...@gmail.com>:
> > > >
> > > > > Hi, Igniters!
> > > > >
> > > > > Could you please review and merge changes from
> > > > > https://github.com/apache/ignite/pull/1956 into master.
> > > > >
> > > > > These changes makes running tests with similar results in TC Run
> > > configs
> > > > > "Ignite 2.0 Tests" as it is in "Ignite Tests".
> > > > >
> > > > > Best regards,
> > > > > Dmitry Pavlov
> > > > >
> > > > > ср, 17 мая 2017 г. в 20:52, Alexey Goncharuk <
> > > alexey.goncharuk@gmail.com
> > > > >:
> > > > >
> > > > > > Great news! Looking forward to getting rid of the unnecessary TC
> > > > > > configurations.
> > > > > >
> > > > > > Once this is done, I think we should also work out if we can use
> > > build
> > > > > > once, run tests approach for RunAll configuration. Does anybody
> > have
> > > a
> > > > > clue
> > > > > > if this is possible?
> > > > > >
> > > > > > 2017-05-17 20:46 GMT+03:00 Dmitry Pavlov <dpavlov.spb@gmail.com
> >:
> > > > > >
> > > > > > > Hi, Igniters!
> > > > > > >
> > > > > > > Alex (al.psc) has created new Teamcity run configurations
> > optimized
> > > > for
> > > > > > > running 2.0 version and later. This project and its run
> > > > configurations
> > > > > > > avoid duplicate tests running for binary and default
> marshallers
> > > > > because
> > > > > > it
> > > > > > > is now the same for 2.0+.
> > > > > > >
> > > > > > > Usage of this run configuration saves us at least 12
> > machine-hours
> > > > for
> > > > > > each
> > > > > > > test run and in future will allow us to get test results
> faster.
> > > > > > >
> > > > > > > Do you have concerns or remarks about using new run
> > configurations
> > > > for
> > > > > > all
> > > > > > > 2.0+ pull requests?
> > > > > > >
> > > > > > > We are now doing final checks of compatibility of these run
> > > > > > configurations
> > > > > > > with code. Any ideas about what is to be migrated are
> > appreciated.
> > > > > > >
> > > > > > > Best Regards,
> > > > > > > Dmitry Pavlov
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: Ignite 2.0 TeamCity Run configurations
Posted by Dmitry Pavlov <dp...@gmail.com>.
Hi Semen,
Thank you for this fix. It is correct to replace to IgniteCacheTestSuite4
in new 2.0 run configurations as we don’t have Binary* analogue.
IgniteBinaryBasicTestSuite was not deleted to avoid failures in old run
configurations. I assumed missing test suite will cause failure on
teamcity. But the first issue shows us it is not a problem. I’ll prepare PR
for removing suite.
IgniteBinaryObjectsCacheTestSuite3 is kept together with
IgniteCacheTestSuite3 for backward compatibility. In Ignite 2.0 tests first
is used, and in Ignite tests - second. And if someone runs old run configs
then most test will be executed anyway. Practice shows not everyone in
community uses new Run Configs for master-based PRs. In future we will be
able to remove not necessary suite.
Sincerely,
Dmitriy Pavlov
пт, 26 мая 2017 г. в 14:00, Semyon Boikov <sb...@gridgain.com>:
> I just found that 'Ignite Cache 4' was not executed on TeamCity since it
> has from suite name in configuration, I fixed it to use
> IgniteCacheTestSuite4, is it correct?
>
> Aslo why we need both IgniteBinaryObjectsCacheTestSuite3 and
> IgniteCacheTestSuite3? And why IgniteBinaryBasicTestSuite is not deleted?
>
> Thanks
>
> On Mon, May 22, 2017 at 6:39 PM, Dmitry Pavlov <dp...@gmail.com>
> wrote:
>
> > Igniters,
> >
> > I've created new PR https://github.com/apache/ignite/pull/1986 without
> > merge conflicts against master. Please review these changes instead of
> > PR1956.
> >
> > Thank you
> >
> > Best Regards,
> > Dmitry Pavlov
> >
> > пн, 22 мая 2017 г. в 13:21, Alexey Goncharuk <alexey.goncharuk@gmail.com
> >:
> >
> > > Thanks, Dmitriy!
> > >
> > > If there are no other objections, I will merge the changes shortly.
> > >
> > > 2017-05-22 13:10 GMT+03:00 Dmitry Pavlov <dp...@gmail.com>:
> > >
> > > > Hi, Igniters!
> > > >
> > > > Could you please review and merge changes from
> > > > https://github.com/apache/ignite/pull/1956 into master.
> > > >
> > > > These changes makes running tests with similar results in TC Run
> > configs
> > > > "Ignite 2.0 Tests" as it is in "Ignite Tests".
> > > >
> > > > Best regards,
> > > > Dmitry Pavlov
> > > >
> > > > ср, 17 мая 2017 г. в 20:52, Alexey Goncharuk <
> > alexey.goncharuk@gmail.com
> > > >:
> > > >
> > > > > Great news! Looking forward to getting rid of the unnecessary TC
> > > > > configurations.
> > > > >
> > > > > Once this is done, I think we should also work out if we can use
> > build
> > > > > once, run tests approach for RunAll configuration. Does anybody
> have
> > a
> > > > clue
> > > > > if this is possible?
> > > > >
> > > > > 2017-05-17 20:46 GMT+03:00 Dmitry Pavlov <dp...@gmail.com>:
> > > > >
> > > > > > Hi, Igniters!
> > > > > >
> > > > > > Alex (al.psc) has created new Teamcity run configurations
> optimized
> > > for
> > > > > > running 2.0 version and later. This project and its run
> > > configurations
> > > > > > avoid duplicate tests running for binary and default marshallers
> > > > because
> > > > > it
> > > > > > is now the same for 2.0+.
> > > > > >
> > > > > > Usage of this run configuration saves us at least 12
> machine-hours
> > > for
> > > > > each
> > > > > > test run and in future will allow us to get test results faster.
> > > > > >
> > > > > > Do you have concerns or remarks about using new run
> configurations
> > > for
> > > > > all
> > > > > > 2.0+ pull requests?
> > > > > >
> > > > > > We are now doing final checks of compatibility of these run
> > > > > configurations
> > > > > > with code. Any ideas about what is to be migrated are
> appreciated.
> > > > > >
> > > > > > Best Regards,
> > > > > > Dmitry Pavlov
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: Ignite 2.0 TeamCity Run configurations
Posted by Semyon Boikov <sb...@gridgain.com>.
I just found that 'Ignite Cache 4' was not executed on TeamCity since it
has from suite name in configuration, I fixed it to use
IgniteCacheTestSuite4, is it correct?
Aslo why we need both IgniteBinaryObjectsCacheTestSuite3 and
IgniteCacheTestSuite3? And why IgniteBinaryBasicTestSuite is not deleted?
Thanks
On Mon, May 22, 2017 at 6:39 PM, Dmitry Pavlov <dp...@gmail.com>
wrote:
> Igniters,
>
> I've created new PR https://github.com/apache/ignite/pull/1986 without
> merge conflicts against master. Please review these changes instead of
> PR1956.
>
> Thank you
>
> Best Regards,
> Dmitry Pavlov
>
> пн, 22 мая 2017 г. в 13:21, Alexey Goncharuk <al...@gmail.com>:
>
> > Thanks, Dmitriy!
> >
> > If there are no other objections, I will merge the changes shortly.
> >
> > 2017-05-22 13:10 GMT+03:00 Dmitry Pavlov <dp...@gmail.com>:
> >
> > > Hi, Igniters!
> > >
> > > Could you please review and merge changes from
> > > https://github.com/apache/ignite/pull/1956 into master.
> > >
> > > These changes makes running tests with similar results in TC Run
> configs
> > > "Ignite 2.0 Tests" as it is in "Ignite Tests".
> > >
> > > Best regards,
> > > Dmitry Pavlov
> > >
> > > ср, 17 мая 2017 г. в 20:52, Alexey Goncharuk <
> alexey.goncharuk@gmail.com
> > >:
> > >
> > > > Great news! Looking forward to getting rid of the unnecessary TC
> > > > configurations.
> > > >
> > > > Once this is done, I think we should also work out if we can use
> build
> > > > once, run tests approach for RunAll configuration. Does anybody have
> a
> > > clue
> > > > if this is possible?
> > > >
> > > > 2017-05-17 20:46 GMT+03:00 Dmitry Pavlov <dp...@gmail.com>:
> > > >
> > > > > Hi, Igniters!
> > > > >
> > > > > Alex (al.psc) has created new Teamcity run configurations optimized
> > for
> > > > > running 2.0 version and later. This project and its run
> > configurations
> > > > > avoid duplicate tests running for binary and default marshallers
> > > because
> > > > it
> > > > > is now the same for 2.0+.
> > > > >
> > > > > Usage of this run configuration saves us at least 12 machine-hours
> > for
> > > > each
> > > > > test run and in future will allow us to get test results faster.
> > > > >
> > > > > Do you have concerns or remarks about using new run configurations
> > for
> > > > all
> > > > > 2.0+ pull requests?
> > > > >
> > > > > We are now doing final checks of compatibility of these run
> > > > configurations
> > > > > with code. Any ideas about what is to be migrated are appreciated.
> > > > >
> > > > > Best Regards,
> > > > > Dmitry Pavlov
> > > > >
> > > >
> > >
> >
>
Re: Ignite 2.0 TeamCity Run configurations
Posted by Dmitry Pavlov <dp...@gmail.com>.
Igniters,
I've created new PR https://github.com/apache/ignite/pull/1986 without
merge conflicts against master. Please review these changes instead of
PR1956.
Thank you
Best Regards,
Dmitry Pavlov
пн, 22 мая 2017 г. в 13:21, Alexey Goncharuk <al...@gmail.com>:
> Thanks, Dmitriy!
>
> If there are no other objections, I will merge the changes shortly.
>
> 2017-05-22 13:10 GMT+03:00 Dmitry Pavlov <dp...@gmail.com>:
>
> > Hi, Igniters!
> >
> > Could you please review and merge changes from
> > https://github.com/apache/ignite/pull/1956 into master.
> >
> > These changes makes running tests with similar results in TC Run configs
> > "Ignite 2.0 Tests" as it is in "Ignite Tests".
> >
> > Best regards,
> > Dmitry Pavlov
> >
> > ср, 17 мая 2017 г. в 20:52, Alexey Goncharuk <alexey.goncharuk@gmail.com
> >:
> >
> > > Great news! Looking forward to getting rid of the unnecessary TC
> > > configurations.
> > >
> > > Once this is done, I think we should also work out if we can use build
> > > once, run tests approach for RunAll configuration. Does anybody have a
> > clue
> > > if this is possible?
> > >
> > > 2017-05-17 20:46 GMT+03:00 Dmitry Pavlov <dp...@gmail.com>:
> > >
> > > > Hi, Igniters!
> > > >
> > > > Alex (al.psc) has created new Teamcity run configurations optimized
> for
> > > > running 2.0 version and later. This project and its run
> configurations
> > > > avoid duplicate tests running for binary and default marshallers
> > because
> > > it
> > > > is now the same for 2.0+.
> > > >
> > > > Usage of this run configuration saves us at least 12 machine-hours
> for
> > > each
> > > > test run and in future will allow us to get test results faster.
> > > >
> > > > Do you have concerns or remarks about using new run configurations
> for
> > > all
> > > > 2.0+ pull requests?
> > > >
> > > > We are now doing final checks of compatibility of these run
> > > configurations
> > > > with code. Any ideas about what is to be migrated are appreciated.
> > > >
> > > > Best Regards,
> > > > Dmitry Pavlov
> > > >
> > >
> >
>
Re: Ignite 2.0 TeamCity Run configurations
Posted by Alexey Goncharuk <al...@gmail.com>.
Thanks, Dmitriy!
If there are no other objections, I will merge the changes shortly.
2017-05-22 13:10 GMT+03:00 Dmitry Pavlov <dp...@gmail.com>:
> Hi, Igniters!
>
> Could you please review and merge changes from
> https://github.com/apache/ignite/pull/1956 into master.
>
> These changes makes running tests with similar results in TC Run configs
> "Ignite 2.0 Tests" as it is in "Ignite Tests".
>
> Best regards,
> Dmitry Pavlov
>
> ср, 17 мая 2017 г. в 20:52, Alexey Goncharuk <al...@gmail.com>:
>
> > Great news! Looking forward to getting rid of the unnecessary TC
> > configurations.
> >
> > Once this is done, I think we should also work out if we can use build
> > once, run tests approach for RunAll configuration. Does anybody have a
> clue
> > if this is possible?
> >
> > 2017-05-17 20:46 GMT+03:00 Dmitry Pavlov <dp...@gmail.com>:
> >
> > > Hi, Igniters!
> > >
> > > Alex (al.psc) has created new Teamcity run configurations optimized for
> > > running 2.0 version and later. This project and its run configurations
> > > avoid duplicate tests running for binary and default marshallers
> because
> > it
> > > is now the same for 2.0+.
> > >
> > > Usage of this run configuration saves us at least 12 machine-hours for
> > each
> > > test run and in future will allow us to get test results faster.
> > >
> > > Do you have concerns or remarks about using new run configurations for
> > all
> > > 2.0+ pull requests?
> > >
> > > We are now doing final checks of compatibility of these run
> > configurations
> > > with code. Any ideas about what is to be migrated are appreciated.
> > >
> > > Best Regards,
> > > Dmitry Pavlov
> > >
> >
>
Re: Ignite 2.0 TeamCity Run configurations
Posted by Dmitry Pavlov <dp...@gmail.com>.
Hi, Igniters!
Could you please review and merge changes from
https://github.com/apache/ignite/pull/1956 into master.
These changes makes running tests with similar results in TC Run configs
"Ignite 2.0 Tests" as it is in "Ignite Tests".
Best regards,
Dmitry Pavlov
ср, 17 мая 2017 г. в 20:52, Alexey Goncharuk <al...@gmail.com>:
> Great news! Looking forward to getting rid of the unnecessary TC
> configurations.
>
> Once this is done, I think we should also work out if we can use build
> once, run tests approach for RunAll configuration. Does anybody have a clue
> if this is possible?
>
> 2017-05-17 20:46 GMT+03:00 Dmitry Pavlov <dp...@gmail.com>:
>
> > Hi, Igniters!
> >
> > Alex (al.psc) has created new Teamcity run configurations optimized for
> > running 2.0 version and later. This project and its run configurations
> > avoid duplicate tests running for binary and default marshallers because
> it
> > is now the same for 2.0+.
> >
> > Usage of this run configuration saves us at least 12 machine-hours for
> each
> > test run and in future will allow us to get test results faster.
> >
> > Do you have concerns or remarks about using new run configurations for
> all
> > 2.0+ pull requests?
> >
> > We are now doing final checks of compatibility of these run
> configurations
> > with code. Any ideas about what is to be migrated are appreciated.
> >
> > Best Regards,
> > Dmitry Pavlov
> >
>
Re: Ignite 2.0 TeamCity Run configurations
Posted by Alexey Goncharuk <al...@gmail.com>.
Great news! Looking forward to getting rid of the unnecessary TC
configurations.
Once this is done, I think we should also work out if we can use build
once, run tests approach for RunAll configuration. Does anybody have a clue
if this is possible?
2017-05-17 20:46 GMT+03:00 Dmitry Pavlov <dp...@gmail.com>:
> Hi, Igniters!
>
> Alex (al.psc) has created new Teamcity run configurations optimized for
> running 2.0 version and later. This project and its run configurations
> avoid duplicate tests running for binary and default marshallers because it
> is now the same for 2.0+.
>
> Usage of this run configuration saves us at least 12 machine-hours for each
> test run and in future will allow us to get test results faster.
>
> Do you have concerns or remarks about using new run configurations for all
> 2.0+ pull requests?
>
> We are now doing final checks of compatibility of these run configurations
> with code. Any ideas about what is to be migrated are appreciated.
>
> Best Regards,
> Dmitry Pavlov
>