You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Mona Chitnis <ch...@yahoo-inc.com> on 2012/10/12 19:42:53 UTC
Review Request: OOZIE-1020 BulkJPAExecutor handling date-time value
incorrectly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7568/
-----------------------------------------------------------
Review request for oozie.
Description
-------
The use of string concatenation in the Bulk monitoring queries was resulting in Oracle DB error "ORA-01843: not a valid month" when the filter criteria were given a date-time parameter.
This addresses bug OOZIE-1020.
https://issues.apache.org/jira/browse/OOZIE-1020
Diffs
-----
trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1397424
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java 1397424
trunk/docs/src/site/twiki/WebServicesAPI.twiki 1397424
Diff: https://reviews.apache.org/r/7568/diff/
Testing
-------
verified with web-service end-to-end test using Oracle DB
Thanks,
Mona Chitnis
Re: Review Request: OOZIE-1020 BulkJPAExecutor handling date-time value
incorrectly
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7568/#review12465
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java
<https://reviews.apache.org/r/7568/#comment26474>
remove space pls.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java
<https://reviews.apache.org/r/7568/#comment26502>
Please modularize each query.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java
<https://reviews.apache.org/r/7568/#comment26503>
Use hash map in place of fixed size array.
- Mohammad Islam
On Oct. 12, 2012, 5:42 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7568/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2012, 5:42 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> The use of string concatenation in the Bulk monitoring queries was resulting in Oracle DB error "ORA-01843: not a valid month" when the filter criteria were given a date-time parameter.
>
>
> This addresses bug OOZIE-1020.
> https://issues.apache.org/jira/browse/OOZIE-1020
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1397424
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java 1397424
> trunk/docs/src/site/twiki/WebServicesAPI.twiki 1397424
>
> Diff: https://reviews.apache.org/r/7568/diff/
>
>
> Testing
> -------
>
> verified with web-service end-to-end test using Oracle DB
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1020 BulkJPAExecutor handling date-time value
incorrectly
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7568/#review12687
-----------------------------------------------------------
Ship it!
Ship It!
- Mohammad Islam
On Oct. 18, 2012, 6:33 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7568/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2012, 6:33 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> The use of string concatenation in the Bulk monitoring queries was resulting in Oracle DB error "ORA-01843: not a valid month" when the filter criteria were given a date-time parameter.
>
>
> This addresses bug OOZIE-1020.
> https://issues.apache.org/jira/browse/OOZIE-1020
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1399483
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java 1399483
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkMonitorJPAExecutor.java 1399483
> trunk/docs/src/site/twiki/WebServicesAPI.twiki 1399483
>
> Diff: https://reviews.apache.org/r/7568/diff/
>
>
> Testing
> -------
>
> verified with web-service end-to-end test using Oracle DB
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1020 BulkJPAExecutor handling date-time value
incorrectly
Posted by Mona Chitnis <ch...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7568/
-----------------------------------------------------------
(Updated Oct. 18, 2012, 6:33 a.m.)
Review request for oozie.
Changes
-------
Addressed Mohammad's comments. And from another offline suggestion, putting a placeholder like ":addbulkfilterpart" in the NamedQuery for upfront indication on reading it, doesnt pass JPA syntax test, so I have skipped it.
Description
-------
The use of string concatenation in the Bulk monitoring queries was resulting in Oracle DB error "ORA-01843: not a valid month" when the filter criteria were given a date-time parameter.
This addresses bug OOZIE-1020.
https://issues.apache.org/jira/browse/OOZIE-1020
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1399483
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java 1399483
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkMonitorJPAExecutor.java 1399483
trunk/docs/src/site/twiki/WebServicesAPI.twiki 1399483
Diff: https://reviews.apache.org/r/7568/diff/
Testing
-------
verified with web-service end-to-end test using Oracle DB
Thanks,
Mona Chitnis