You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@lyra.org> on 2001/12/06 10:46:23 UTC
Re: svn commit: rev 613 - trunk/subversion/bindings/java/jni
On Wed, Dec 05, 2001 at 04:25:29PM -0600, XelaRellum@tigris.org wrote:
>...
> --- OLD/trunk/subversion/bindings/java/jni/item.c Wed Dec 5 16:25:29 2001
> +++ NEW/trunk/subversion/bindings/java/jni/item.c Wed Dec 5 16:25:29 2001
>...
> @@ -27,8 +27,8 @@
> * utility function to create a java Item
> */
> jobject
> -svn_jni_item__create(JNIEnv *env, jobject jpath, jobject jstatus,
> - jboolean *hasException)
> +item__create(JNIEnv *env, jobject jpath, jobject jstatus,
> + jboolean *hasException)
> {
Any function that is linker-visible from a library *must* have the svn
prefix. Since the above function does not have "static" on it, then it must
include the prefix.
The prefix on a function doesn't have to match the filename. So you can
still call it item.c and have svn_jni_* function in there.
I might suggest svn_jni__item_create() since the function "item_create" is
the unit, and is private.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: rev 613 - trunk/subversion/bindings/java/jni
Posted by Alexander Mueller <al...@littleblue.de>.
Probably you are right. But anyhow. First I would like to SEE something happen in the Java subversion library. I tried it to be as pretty as possible. But there was a LOT of overhead
dealing with Java/Apr/Svn/C. So now I just want to be able to run a simple "status" request
from Java. As soon as this works I will re-enable the svn_jni_ prefix.
Alex
Greg Stein schrieb:
> On Wed, Dec 05, 2001 at 04:25:29PM -0600, XelaRellum@tigris.org wrote:
> >...
> > --- OLD/trunk/subversion/bindings/java/jni/item.c Wed Dec 5 16:25:29 2001
> > +++ NEW/trunk/subversion/bindings/java/jni/item.c Wed Dec 5 16:25:29 2001
> >...
> > @@ -27,8 +27,8 @@
> > * utility function to create a java Item
> > */
> > jobject
> > -svn_jni_item__create(JNIEnv *env, jobject jpath, jobject jstatus,
> > - jboolean *hasException)
> > +item__create(JNIEnv *env, jobject jpath, jobject jstatus,
> > + jboolean *hasException)
> > {
>
> Any function that is linker-visible from a library *must* have the svn
> prefix. Since the above function does not have "static" on it, then it must
> include the prefix.
>
> The prefix on a function doesn't have to match the filename. So you can
> still call it item.c and have svn_jni_* function in there.
>
> I might suggest svn_jni__item_create() since the function "item_create" is
> the unit, and is private.
>
> Cheers,
> -g
>
> --
> Greg Stein, http://www.lyra.org/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org