You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/16 17:06:36 UTC

[GitHub] [tvm] tqchen commented on a change in pull request #7153: [RUNTIME] Add libbacktrace for backtraces with line numbers

tqchen commented on a change in pull request #7153:
URL: https://github.com/apache/tvm/pull/7153#discussion_r595365614



##########
File path: apps/android_deploy/app/src/main/jni/Application.mk
##########
@@ -27,7 +27,7 @@ include $(config)
 
 APP_STL := c++_static
 
-APP_CPPFLAGS += -DDMLC_LOG_STACK_TRACE=0 -DTVM4J_ANDROID=1 -std=c++14 -Oz -frtti
+APP_CPPFLAGS += -DDMLC_USE_LOGGING_LIBRARY=\<tvm/runtime/logging.h\> -DTVM_BACKTRACE_DISABLED=1 -DTVM4J_ANDROID=1 -std=c++14 -Oz -frtti

Review comment:
       consider move the def of -DDMLC_USE_LOGGING_LIBRARY=\<tvm/runtime/logging.h\> -DTVM_BACKTRACE_DISABLED=1 into the all in one file in tvm_runtime.h (very beginning)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org