[jira] [Work logged] (ARTEMIS-3573) Support PropertiesLoginModule custom password codecs

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARTEMIS-3573?focusedWorklogId=708217&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-708217 ]

ASF GitHub Bot logged work on ARTEMIS-3573:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Jan/22 10:53
            Start Date: 13/Jan/22 10:53
    Worklog Time Spent: 10m 
      Work Description: brusdev commented on a change in pull request #3851:
URL: https://github.com/apache/activemq-artemis/pull/3851#discussion_r783845942



##########
File path: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/DefaultSensitiveStringCodec.java
##########
@@ -188,6 +208,16 @@ public String encode(String secret) throws Exception {
          BigInteger n = new BigInteger(encoding);
          return n.toString(16);
       }
+
+      @Override
+      public boolean verify(char[] inputValue, String storedValue) {
+         try {
+            return Objects.equals(storedValue, encode(String.valueOf(inputValue)));

Review comment:
       Used SensitiveDataCodec.verify(T, T)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 708217)
    Time Spent: 4h  (was: 3h 50m)

> Support PropertiesLoginModule custom password codecs
> ----------------------------------------------------
>
>                 Key: ARTEMIS-3573
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3573
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Domenico Francesco Bruscino
>            Assignee: Domenico Francesco Bruscino
>            Priority: Major
>          Time Spent: 4h
>  Remaining Estimate: 0h
>
> The `PropertiesLoginModule` login module supports only the `DefaultSensitiveStringCodec` codec to verify the user passwords.
> Add a property to set a custom password codec, i.e. org.apache.activemq.jaas.properties.password.codec="org.apache.activemq.artemis.tests.integration.security.MD5SensitiveDataCodec"



--
This message was sent by Atlassian Jira
(v8.20.1#820001)