You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/09/13 12:40:40 UTC

[GitHub] [fineract] galovics commented on a diff in pull request #2573: FINERACT-1727: Introduce Lombok to accountnumberformat module

galovics commented on code in PR #2573:
URL: https://github.com/apache/fineract/pull/2573#discussion_r969565384


##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/accountnumberformat/data/AccountNumberFormatDataValidator.java:
##########
@@ -44,9 +47,12 @@
 import org.springframework.stereotype.Component;
 
 @Component
+@Data
+@NoArgsConstructor
+@Accessors(chain = true)

Review Comment:
   Why the Accessors annotation?
   The NoArgsConstructor can be switched over to RequiredArgsConstructor if the field is kept as final.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org