[jira] [Commented] (TAJO-1882) Clean up GreedyHeuristicJoinOrderAlgorithm::getCost APIs

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAJO-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14952677#comment-14952677 ] 

ASF GitHub Bot commented on TAJO-1882:
--------------------------------------

GitHub user dkhwangbo opened a pull request:

    https://github.com/apache/tajo/pull/817

    TAJO-1882: Clean up GreedyHeuristicJoinOrderAlgorithm::getCost APIs

    I found that the cause of ambiguity is GreedyHeuristicJoinOrderAlgorithm::getCost(JoinVertex joinVertex). so, change this name and rewrite the part which call this function.
    All the test is passed via mvn clean install.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dkhwangbo/tajo TAJO-1882

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/817.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #817
    
----
commit 069598a8eed81573fbde7115a25f877c97249fc4
Author: Dongkyu Hwangbo <hw...@gmail.com>
Date:   2015-10-12T05:48:18Z

    initial commit

----


> Clean up GreedyHeuristicJoinOrderAlgorithm::getCost APIs
> --------------------------------------------------------
>
>                 Key: TAJO-1882
>                 URL: https://issues.apache.org/jira/browse/TAJO-1882
>             Project: Tajo
>          Issue Type: Improvement
>            Reporter: Hyunsik Choi
>            Assignee: Dongkyu Hwangbo
>            Priority: Trivial
>              Labels: newbie
>
> See the title. The definition of {{GreedyHeuristicJoinOrderAlgorithm::getCost}} is somewhat ambiguous. In Java 8, it requires explicitly type casting. We can clean up its APIs by renaming them to be different.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)