[GitHub] [incubator-superset] rusackas commented on a change in pull request #8734: [Explore] Fix annotation layer select box formatting

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #8734: [Explore] Fix annotation layer select box formatting
URL: https://github.com/apache/incubator-superset/pull/8734#discussion_r353400490
 
 

 ##########
 File path: superset/assets/src/explore/components/controls/AnnotationLayer.jsx
 ##########
 @@ -331,6 +332,16 @@ export default class AnnotationLayer extends React.PureComponent {
     this.props.close();
   }
 
+  renderOption(option) {
 
 Review comment:
   I was wondering the same thing. The JS-based character number may still exhibit issues if the widths of characters are wide enough to cause a linewrap. It might be solvable with just some CSS like:
   ```
   .cleverSpanSelectorHere {
     white-space: nowrap;
     overflow: hidden;
     text-overflow: ellipsis;
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org