You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "AndrewJSchofield (via GitHub)" <gi...@apache.org> on 2025/11/24 17:19:48 UTC

[PR] MINOR: Bump LATEST_PRODUCTION for 4.2-IV1 [kafka]

AndrewJSchofield opened a new pull request, #20977:
URL: https://github.com/apache/kafka/pull/20977

   Bump latest production metadata version to 4.2-IV1 to enable share groups and streams groups by default.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Bump LATEST_PRODUCTION to 4.2-IV1 [kafka]

Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield merged PR #20977:
URL: https://github.com/apache/kafka/pull/20977


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Bump LATEST_PRODUCTION for 4.2-IV1 [kafka]

Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #20977:
URL: https://github.com/apache/kafka/pull/20977#discussion_r2558451989


##########
tests/kafkatest/version.py:
##########
@@ -248,4 +248,9 @@ def get_version(node=None):
 
 # 4.2.x version
 V_4_2_0 = KafkaVersion("4.2.0")
-LATEST_4_2 = V_4_2_0
+V_4_2_1 = KafkaVersion("4.2.1")
+LATEST_4_2 = V_4_2_1
+
+# 4.3.x version
+V_4_3_0 = KafkaVersion("4.3.0")

Review Comment:
   Seems this is unused. We would only need to add this after we release AK 4.3.0, and only for `trunk / 4.4.0-SNAPSHOT` version.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Bump LATEST_PRODUCTION for 4.2-IV1 [kafka]

Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #20977:
URL: https://github.com/apache/kafka/pull/20977#discussion_r2558453623


##########
tests/kafkatest/version.py:
##########
@@ -248,4 +248,9 @@ def get_version(node=None):
 
 # 4.2.x version
 V_4_2_0 = KafkaVersion("4.2.0")
-LATEST_4_2 = V_4_2_0
+V_4_2_1 = KafkaVersion("4.2.1")
+LATEST_4_2 = V_4_2_1

Review Comment:
   This seems not to be correct... We use `LATEST_4_2` in system tests, but `4.2.1` is no release yet, so this might break system test trying to test `4.2.0` is they only specify `LATEST_4_2` (what most system test do...)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Bump LATEST_PRODUCTION for 4.2-IV1 [kafka]

Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #20977:
URL: https://github.com/apache/kafka/pull/20977#discussion_r2558453623


##########
tests/kafkatest/version.py:
##########
@@ -248,4 +248,9 @@ def get_version(node=None):
 
 # 4.2.x version
 V_4_2_0 = KafkaVersion("4.2.0")
-LATEST_4_2 = V_4_2_0
+V_4_2_1 = KafkaVersion("4.2.1")
+LATEST_4_2 = V_4_2_1

Review Comment:
   This seems not to be correct... We use `LATEST_4_2` in system tests, but `4.2.1` is no release yet, so this might break system test trying to test `4.2.0` is they only specify `LATEST_4_2` (what most system test do...)
   
   And for `trunk` (in contrast to `4.2` branch), after 4.2.0 was release, we are going to use `LATEST_4_2`, and it must point to `4.2.0` not to unreleased `4.2.1` to work as expected, and not break system tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Bump LATEST_PRODUCTION for 4.2-IV1 [kafka]

Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield commented on code in PR #20977:
URL: https://github.com/apache/kafka/pull/20977#discussion_r2559206864


##########
tests/kafkatest/version.py:
##########
@@ -248,4 +248,9 @@ def get_version(node=None):
 
 # 4.2.x version
 V_4_2_0 = KafkaVersion("4.2.0")
-LATEST_4_2 = V_4_2_0
+V_4_2_1 = KafkaVersion("4.2.1")
+LATEST_4_2 = V_4_2_1

Review Comment:
   Got it. Thanks for the review.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Bump LATEST_PRODUCTION for 4.2-IV1 [kafka]

Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #20977:
URL: https://github.com/apache/kafka/pull/20977#discussion_r2558451989


##########
tests/kafkatest/version.py:
##########
@@ -248,4 +248,9 @@ def get_version(node=None):
 
 # 4.2.x version
 V_4_2_0 = KafkaVersion("4.2.0")
-LATEST_4_2 = V_4_2_0
+V_4_2_1 = KafkaVersion("4.2.1")
+LATEST_4_2 = V_4_2_1
+
+# 4.3.x version
+V_4_3_0 = KafkaVersion("4.3.0")

Review Comment:
   Seems this is unused. We would only need to add this after we release AK 4.3.0.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org