You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@age.apache.org by GitBox <gi...@apache.org> on 2022/05/23 21:58:52 UTC
[GitHub] [incubator-age] vinzenz opened a new pull request, #219: DRAFT: Merge actions
vinzenz opened a new pull request, #219:
URL: https://github.com/apache/incubator-age/pull/219
An attempt to add support for merge actions to AGE. This is currently WIP and I will need some help understanding the code a bit better.
Currently I am lost on what to do with the parsed code, to be able handling the on create/on match cases.
I somehow don't understand how everything works at this moment, so I will need some pointers or some explanation how to continue, if one of you is willing to do so, it would be much appreciated, for me it's a big missing piece to the puzzle on making it convenient to use, otherwise I will be forced to have a lot of round trips to the server for data insertion/updates.
Signed-off-by: Vinzenz Feenstra <ev...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] jrgemignani commented on pull request #219: Merge actions
Posted by GitBox <gi...@apache.org>.
jrgemignani commented on PR #219:
URL: https://github.com/apache/age/pull/219#issuecomment-1382298469
@vinzenz @JoshInnis What is the current status of this PR? The PR looks to need, at the very least, to be rebased against the current master branch. But, it is not known if there was a plan to go forward, or not at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] jrgemignani commented on pull request #219: Merge actions
Posted by GitBox <gi...@apache.org>.
jrgemignani commented on PR #219:
URL: https://github.com/apache/age/pull/219#issuecomment-1382349111
@vinzenz Thank you for the quick response and the attempt! I will try to see about getting MERGE actions added to our list of tasks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] vinzenz commented on pull request #219: Merge actions
Posted by GitBox <gi...@apache.org>.
vinzenz commented on PR #219:
URL: https://github.com/apache/age/pull/219#issuecomment-1382304802
@jrgemignani well it looks like, i don't have the knowhow to finish it and not enough time to get it in, so i will close it.
It was marked as draft already anyway as it is not even nearly finished.
Closing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] vinzenz closed pull request #219: Merge actions
Posted by GitBox <gi...@apache.org>.
vinzenz closed pull request #219: Merge actions
URL: https://github.com/apache/age/pull/219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-age] JoshInnis commented on pull request #219: Merge actions
Posted by GitBox <gi...@apache.org>.
JoshInnis commented on PR #219:
URL: https://github.com/apache/incubator-age/pull/219#issuecomment-1135338877
Hi @vinzenz
So a couple things. Merge actions is an issue that we need to address, so thank you for trying to get the ball rolling. :). BUT, you need to do more than change the expected out from the regression tests if you change the regression SQL, AND you need to throw an error if a user inputs a grammatically correct statement with MERGE actions that we cannot currently handle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-age] JoshInnis commented on pull request #219: Merge actions
Posted by GitBox <gi...@apache.org>.
JoshInnis commented on PR #219:
URL: https://github.com/apache/incubator-age/pull/219#issuecomment-1135336279
Hi @vinzenz,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org