You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/08/15 15:26:08 UTC

[GitHub] [iotdb] qiaojialin commented on a diff in pull request #6968: [IOTDB-3843] Refine the using of setting read-only

qiaojialin commented on code in PR #6968:
URL: https://github.com/apache/iotdb/pull/6968#discussion_r945725363


##########
server/src/main/java/org/apache/iotdb/db/wal/allocation/AbstractNodeAllocationStrategy.java:
##########
@@ -49,7 +49,6 @@ public AbstractNodeAllocationStrategy() {
               Arrays.asList(config.getWalDirs()), DirectoryStrategyType.SEQUENCE_STRATEGY);
     } catch (DiskSpaceInsufficientException e) {
       logger.error("All disks of wal folders are full, change system mode to read-only.", e);
-      config.setReadOnly(true);

Review Comment:
   Why delete this？If you delete this, which code relates the error?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org