You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@echarts.apache.org by GitBox <gi...@apache.org> on 2021/11/07 17:03:45 UTC

[GitHub] [echarts-handbook] plainheart opened a new pull request #23: chore: add more strategies for generating contributors.

plainheart opened a new pull request #23:
URL: https://github.com/apache/echarts-handbook/pull/23

Currently, we are generating the contributors from the git log. It's fast but there are some drawbacks,

1. The git username may not be consistent with GitHub account name.

e.g. https://echarts.apache.org/handbook/zh/get-started/

2. The author's name of the merged commit or the commit committed through GitHub is usually the nick/full name instead of the account name.

e.g. https://apache.github.io/echarts-handbook/en/get-started

These two issues can both make the contributor's link inaccessible.

So I'm adding the following two new strategies,

One([ghAPI](https://github.com/apache/echarts-handbook/blob/0ea4602ce18694988aa9e26749ea9ef15b65111c/build/generate-contributors.js#L63-L87)) is to fetch by GitHub API, but unfortunately, it has a rate limit.

Another([ghWeb](https://github.com/apache/echarts-handbook/blob/0ea4602ce18694988aa9e26749ea9ef15b65111c/build/generate-contributors.js#L94-L125)) is to fetch from the GitHub website. It looks good to me and is working well. But it may have potential network/request/parse error since it needs to access the website and parse the HTML document.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For additional commands, e-mail: dev-help@echarts.apache.org

[GitHub] [echarts-handbook] pissang commented on pull request #23: chore: add more strategies for generating contributors.

Posted by GitBox <gi...@apache.org>.

pissang commented on pull request #23:
URL: https://github.com/apache/echarts-handbook/pull/23#issuecomment-965994471


   Seems I was wrong. Only 60 requests per hour if we don't use token. Seems not enough if we have more articles


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For additional commands, e-mail: dev-help@echarts.apache.org

[GitHub] [echarts-handbook] pissang merged pull request #23: chore: add more strategies for generating contributors.

Posted by GitBox <gi...@apache.org>.

pissang merged pull request #23:
URL: https://github.com/apache/echarts-handbook/pull/23


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For additional commands, e-mail: dev-help@echarts.apache.org

[GitHub] [echarts-handbook] pissang edited a comment on pull request #23: chore: add more strategies for generating contributors.

Posted by GitBox <gi...@apache.org>.

pissang edited a comment on pull request #23:
URL: https://github.com/apache/echarts-handbook/pull/23#issuecomment-965993126


   Good job! I think the rate limit of gh api will not be an issue since it won't be executed often


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For additional commands, e-mail: dev-help@echarts.apache.org

[GitHub] [echarts-handbook] pissang edited a comment on pull request #23: chore: add more strategies for generating contributors.

Posted by GitBox <gi...@apache.org>.

pissang edited a comment on pull request #23:
URL: https://github.com/apache/echarts-handbook/pull/23#issuecomment-965994471


   Seems I was wrong. Only 60 requests per hour if we don't use token. Not enough if we have more articles


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For additional commands, e-mail: dev-help@echarts.apache.org

[GitHub] [echarts-handbook] pissang commented on pull request #23: chore: add more strategies for generating contributors.

Posted by GitBox <gi...@apache.org>.

pissang commented on pull request #23:
URL: https://github.com/apache/echarts-handbook/pull/23#issuecomment-965993126


   The rate limit of gh api should not be an issue since it won't be executed often


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For additional commands, e-mail: dev-help@echarts.apache.org

[GitHub] [echarts-handbook] pissang commented on pull request #23: chore: add more strategies for generating contributors.

Posted by GitBox <gi...@apache.org>.

pissang commented on pull request #23:
URL: https://github.com/apache/echarts-handbook/pull/23#issuecomment-965995069


   Looks good to me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For additional commands, e-mail: dev-help@echarts.apache.org