[GitHub] [spark] otterc commented on a diff in pull request #41225: [SPARK-43583][CORE] get MergedBlockedMetaReqHandler from the delegate instead of the SaslRpcHandler instance

["otterc (via GitHub)" <gi...@apache.org>]

otterc commented on code in PR #41225:
URL: https://github.com/apache/spark/pull/41225#discussion_r1198505545


##########
common/network-common/src/main/java/org/apache/spark/network/crypto/AuthRpcHandler.java:
##########
@@ -139,8 +139,4 @@ protected boolean doAuthChallenge(
     return true;
   }
 
-  @Override
-  public MergedBlockMetaReqHandler getMergedBlockMetaReqHandler() {
-    return saslHandler.getMergedBlockMetaReqHandler();
-  }

Review Comment:
   Yes, we didn't test with encryption enabled and this was missed. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org