You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by GitBox <gi...@apache.org> on 2022/09/30 11:22:47 UTC

[GitHub] [bigtop] kevinw66 opened a new pull request, #1027: BIGTOP-3825: remove debug messages on Solr build script

kevinw66 opened a new pull request, #1027:
URL: https://github.com/apache/bigtop/pull/1027

   <!--
     Thanks for sending a pull request!
       1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute
       2. Make sure your PR title starts with JIRA issue id, e.g., 'BIGTOP-3638: Your PR title ...'.
   -->
   
   ### Description of PR
   
   
   ### How was this patch tested?
   
   
   ### For code changes:
   
   - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'BIGTOP-3638. Your PR title ...')?
   - [ ] Make sure that newly added files do not have any licensing issues. When in doubt refer to https://www.apache.org/licenses/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bigtop] sekikn commented on pull request #1027: BIGTOP-3825: remove debug messages on Solr build script

Posted by GitBox <gi...@apache.org>.
sekikn commented on PR #1027:
URL: https://github.com/apache/bigtop/pull/1027#issuecomment-1272423039

   Merged into master. Thanks @kevinw66!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bigtop] sekikn commented on pull request #1027: BIGTOP-3825: remove debug messages on Solr build script

Posted by GitBox <gi...@apache.org>.
sekikn commented on PR #1027:
URL: https://github.com/apache/bigtop/pull/1027#issuecomment-1263621233

   Oh sorry, my comment may have been misleading. I meant L155 and L157 is unnecessary, but I'm not sure if we could remove L156 without any problem. Can we remove it @kevinw66?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bigtop] sekikn commented on pull request #1027: BIGTOP-3825: remove debug messages on Solr build script

Posted by GitBox <gi...@apache.org>.
sekikn commented on PR #1027:
URL: https://github.com/apache/bigtop/pull/1027#issuecomment-1272422970

   +1, sorry for my late response.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bigtop] kevinw66 commented on pull request #1027: BIGTOP-3825: remove debug messages on Solr build script

Posted by GitBox <gi...@apache.org>.
kevinw66 commented on PR #1027:
URL: https://github.com/apache/bigtop/pull/1027#issuecomment-1263713337

   > Oh sorry, my comment may have been misleading. I meant L155 and L157 is unnecessary, but I'm not sure if we could remove L156 without any problem. Can we remove it @kevinw66?
   
   Yes, that's debug code which I'm trying to view the files under conf dir


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bigtop] sekikn merged pull request #1027: BIGTOP-3825: remove debug messages on Solr build script

Posted by GitBox <gi...@apache.org>.
sekikn merged PR #1027:
URL: https://github.com/apache/bigtop/pull/1027


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org