You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "imcheck (via GitHub)" <gi...@apache.org> on 2023/08/18 02:25:30 UTC

[I] Support helm chart to use a `Secret` resource to hide metadata storage db credentails. (druid)

imcheck opened a new issue, #14867:
URL: https://github.com/apache/druid/issues/14867

   ### Motivation
   
   I have tried to deploy druid using helm chart.
   the helm chart doesn't support to inject environment variables related to metadata storage db credentials using `Secret` resource.
   There's no way to inject the credentials unless using `ConfigMap` defined in values.yaml.
   
   
   ### Proposed changes
   
   - Add a way to pull some configs like db credentials (`druid_metadata_storage_connector_user`, `druid_metadata_storage_connector_password`) to each process (broker, historical, ...) from `Secret` resource.
   - It can be custom `Secret` user made outside this helm chart.
   
   ### Rationale
   
   As I said on the above, it supports only to pull configs from `ConfigMap`.
   It's hard to operate and manage `values.yaml` of this druid helm chart.
   
   ### Operational impact
   
   It's just add changes. so, it keeps backward compatibility.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [I] Support helm chart to use a `Secret` resource to hide metadata storage db credentails. (druid)

Posted by "asdf2014 (via GitHub)" <gi...@apache.org>.
asdf2014 closed issue #14867: Support helm chart to use a `Secret` resource to hide metadata storage db credentails.
URL: https://github.com/apache/druid/issues/14867


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [I] Support helm chart to use a `Secret` resource to hide metadata storage db credentails. (druid)

Posted by "jwitko (via GitHub)" <gi...@apache.org>.
jwitko commented on issue #14867:
URL: https://github.com/apache/druid/issues/14867#issuecomment-1684130738

   @imcheck I was able to accomplish this by adding the following to the helm chart values:
   ```
     env:
       - name: druid_metadata_storage_connector_password
         valueFrom:
           secretKeyRef:
             name: druid-pg-app
             key: password
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [I] Support helm chart to use a `Secret` resource to hide metadata storage db credentails. (druid)

Posted by "imcheck (via GitHub)" <gi...@apache.org>.
imcheck commented on issue #14867:
URL: https://github.com/apache/druid/issues/14867#issuecomment-1685556770

   @jwitko Thank you for replying 👍 However, it seems that the druid chart (`0.3.5` chart version) doesn't support it.
   I also tried adding the values in `values.yaml`, but it didn't change anything.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [I] Support helm chart to use a `Secret` resource to hide metadata storage db credentails. (druid)

Posted by "jwitko (via GitHub)" <gi...@apache.org>.
jwitko commented on issue #14867:
URL: https://github.com/apache/druid/issues/14867#issuecomment-1686477903

   Sorry you are right, I forgot I was using a vendored copy of this chart that has the fixes in the above linked PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [I] Support helm chart to use a `Secret` resource to hide metadata storage db credentails. (druid)

Posted by "asdf2014 (via GitHub)" <gi...@apache.org>.
asdf2014 commented on issue #14867:
URL: https://github.com/apache/druid/issues/14867#issuecomment-1956192443

   @imcheck @jwitko Thanks for your contribution. As mentioned in PR [https://github.com/apache/druid/pull/15904](https://github.com/apache/druid/pull/15904), we have migrated the Helm Chart to a [new repository](https://github.com/asdf2014/druid-helm), you are welcome to raise up new one there and we can maintain the Druid Helm Chart together in new repository. And this PR will closed soon. Thank you again for your understanding and collaboration.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org