You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/09/01 16:37:27 UTC

[GitHub] [airflow] XD-DENG commented on a change in pull request #10678: Add section for official source code

XD-DENG commented on a change in pull request #10678:
URL: https://github.com/apache/airflow/pull/10678#discussion_r481281237



##########
File path: README.md
##########
@@ -122,7 +123,14 @@ pip install apache-airflow[postgres,google]==1.10.12 \
  --constraint "https://raw.githubusercontent.com/apache/airflow/constraints-1.10.12/constraints-3.7.txt"
 ```
 
+## Official source code
+
+There is only one "official" source code repository for Apache Airflow, like all ASF projects: https://downloads.apache.org. Official releases are cryptographically signed by the release manager and placed in the Apache svn next to the file, its checksum and archived by ASF in case of any legal disputes.

Review comment:
       Typo around `...its checksum and archived by ASF...`?

##########
File path: README.md
##########
@@ -122,7 +123,14 @@ pip install apache-airflow[postgres,google]==1.10.12 \
  --constraint "https://raw.githubusercontent.com/apache/airflow/constraints-1.10.12/constraints-3.7.txt"
 ```
 
+## Official source code
+
+There is only one "official" source code repository for Apache Airflow, like all ASF projects: https://downloads.apache.org. Official releases are cryptographically signed by the release manager and placed in the Apache svn next to the file, its checksum and archived by ASF in case of any legal disputes.
+
+Other ways of retrieving source code are just "convenience" methods. For example, tags in GitHub is only a convenience way to mark that those are the git project sources that were used to generate the "official" source package. What is in the tag is not a concern when it comes to releasing the software, but what matters most is what goes into the official package.

Review comment:
       maybe typos for `tags`/`tag` and `is`/`are`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org