You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Anli Shundi <as...@tibco.com> on 2001/09/11 21:44:17 UTC

[PATCH] doc for p4add attached; RE: p4add; source code attached

Thanks for the quick addition and sorry for not following
guidelines the previous time.  Here's the patched doc.

--Anli


-----Original Message-----
From: Peter Donald [mailto:donaldp@apache.org]
Sent: Monday, September 10, 2001 9:35 PM
To: ant-dev@jakarta.apache.org
Subject: Re: p4add; source code attached


Hi,

I added the task but no documentation. Could you create doc file and send
it?

Also you should probably follow guidelines at 
http://jakarta.apache.org/site/source.html for supplying patches or else it 
makes it harder for us to identify patches sometimes ;)

On Thu, 6 Sep 2001 02:52, Anli Shundi wrote:
> I wrote for my own use perforce's p4add optional task --
> seems this was already requested.
>
> Is it possible to add it to the distribution ?
>
> Options:
> 	commandlength is a positive integer specifying the maximum length
> 		of the commandline when adding files.  Defaults to 450,
> 		higher values mean faster execution, but also possible
> failures.
> 		OPTIONAL
>
> 	changelist is a positive integer specifying the changelist.  If not
> specified
> 		the files will be added to the default one.  OPTIONAL.
>
> Usage sample:
>
> 	Require a changelist, add all java files starting from a directory,
> and submit
>
> 		<p4change/>
> 		<p4add commandlength="20000" changelist="${p4.change}">
> 			<fileset dir="../dir/src/" includes="**/*.java"/>
> 		</p4add>
> 		<p4submit change="${p4.change}"/>
>
> Files to add:
> 	src/main/org/apache/tools/ant/taskdefs/optional/perforce/P4Add.java
>
> Files to change:
> 	1. In src/main/org/apache/tools/ant/taskdefs/defaults.properties add
>
> 	p4add=org.apache.tools.ant.taskdefs.optional.perforce.P4Add
>
> 	2. Update docs/manual/OptionalTasks/perforce.html
>
>
> Anli Shundi                      ashundi@tibco.com
> Product Development Group        office: (919) 969-6518
> TIBCO Software Inc.
>
> www.extensibility.com  |  www.XMLschema.com  |  www.tibco.com

-- 
Cheers,

Pete

*-----------------------------------------------------*
| For those who refuse to understand, no explanation  |
| will ever suffice. For those who refuse to believe, |
| no evidence will ever suffice.                      |
*-----------------------------------------------------*


Re: [PATCH] doc for p4add attached; RE: p4add; source code attached

Posted by Peter Donald <do...@apache.org>.
On Wed, 12 Sep 2001 05:44, Anli Shundi wrote:
> Thanks for the quick addition and sorry for not following
> guidelines the previous time.  Here's the patched doc.

applied - thanks!

-- 
Cheers,

Pete

*------------------------------------------------------*
|  Hlade's Law: If you have a difficult task, give it  |
|     to a lazy person -- they will find an easier     |
|                    way to do it.                     |
*------------------------------------------------------*