[GitHub] [orc] pavibhai commented on a change in pull request #653: ORC-759: StructBatchReader should always skip processing on the rootReader

[GitBox <gi...@apache.org>]

pavibhai commented on a change in pull request #653:
URL: https://github.com/apache/orc/pull/653#discussion_r599982700



##########
File path: java/core/src/java/org/apache/orc/impl/reader/tree/StructBatchReader.java
##########
@@ -20,11 +20,18 @@
 import org.apache.hadoop.hive.ql.exec.vector.ColumnVector;
 import org.apache.hadoop.hive.ql.exec.vector.VectorizedRowBatch;
 import org.apache.orc.impl.OrcFilterContextImpl;
+import org.apache.orc.impl.PositionProvider;
 import org.apache.orc.impl.TreeReaderFactory;
+import org.apache.orc.impl.reader.StripePlanner;
 
 import java.io.IOException;
 import java.util.Set;
 
+/**
+ * Handles the Struct rootType for batch handling. The handling assumes that the root
+ * {@link org.apache.orc.impl.TreeReaderFactory.StructTreeReader} has no nulls, this is required as
+ * the {@link VectorizedRowBatch} does not represent the root Struct as a vector.

Review comment:
       Changed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org