[GitHub] [spark] dongjoon-hyun commented on pull request #37284: [SPARK-39867][SQL] Global limit should not inherit OrderPreservingUnaryNode

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on PR #37284:
URL: https://github.com/apache/spark/pull/37284#issuecomment-1203537156

   Hi, @cloud-fan . 
   Unfortunately, the backport commit on branch-3.3 seems to break the Scala style. Could you fix it in branch-3.3?
   ```
   sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/EliminateSortsSuite.scala:118:
   File line length exceeds 100 characters
   ```
   
   ```scala
   - val unnecessaryReordered = orderedPlan.limit(2).select('a).sortBy('a.asc, 'b.desc_nullsFirst)
   + val unnecessaryReordered = LocalLimit(2, orderedPlan).select('a).sortBy('a.asc, 'b.desc_nullsFirst)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org