You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/27 22:10:26 UTC
[GitHub] [tvm] driazati opened a new pull request, #11152: [ci][onnx] Relax more test tolerances
driazati opened a new pull request, #11152:
URL: https://github.com/apache/tvm/pull/11152
Following on #11042, this changes tolerances to fix some other ONNX test failures that have come up in the past several days
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] github-actions[bot] commented on pull request #11152: [ci][onnx] Relax more test tolerances
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11152:
URL: https://github.com/apache/tvm/pull/11152#issuecomment-1117988045
It has been a while since this PR was updated, @areusch please leave a review or address the outstanding comments. @driazati if this PR is still a work in progress, please [convert it to a draft](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request#converting-a-pull-request-to-a-draft) until it is ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #11152: [ci][onnx] Relax more test tolerances
Posted by GitBox <gi...@apache.org>.
masahi commented on PR #11152:
URL: https://github.com/apache/tvm/pull/11152#issuecomment-1132130066
yeah, getting accuracy aligned with frameworks is challenging, due to slight difference in how low-level numerics is done (fixed point vs fp32 etc). In PyTorch frontnend, we skip accuracy check entirely for quantized ops / models.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #11152: [ci][onnx] Relax more test tolerances
Posted by GitBox <gi...@apache.org>.
areusch commented on PR #11152:
URL: https://github.com/apache/tvm/pull/11152#issuecomment-1124102030
cc @altanh can you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] altanh commented on pull request #11152: [ci][onnx] Relax more test tolerances
Posted by GitBox <gi...@apache.org>.
altanh commented on PR #11152:
URL: https://github.com/apache/tvm/pull/11152#issuecomment-1130541031
I'm suspicious of a single value being ~1e-2 off while the rest are below 1e-5... tricky. We could reduce tolerances to that but that's quite a reduction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] github-actions[bot] commented on pull request #11152: [ci][onnx] Relax more test tolerances
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11152:
URL: https://github.com/apache/tvm/pull/11152#issuecomment-1130339316
It has been a while since this PR was updated, @altanh @areusch please leave a review or address the outstanding comments. @driazati if this PR is still a work in progress, please [convert it to a draft](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request#converting-a-pull-request-to-a-draft) until it is ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on pull request #11152: [ci][onnx] Relax more test tolerances
Posted by GitBox <gi...@apache.org>.
driazati commented on PR #11152:
URL: https://github.com/apache/tvm/pull/11152#issuecomment-1132120435
Closing in favor of #11376, agreed that the tolerances are too high here (and not even enough for all the failures I've seen, some are off by `atol=0.02`) to merge and would silently indicate nothing is wrong. We don't really have any other choice but to disable these tests until someone can identify and fix the values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati closed pull request #11152: [ci][onnx] Relax more test tolerances
Posted by GitBox <gi...@apache.org>.
driazati closed pull request #11152: [ci][onnx] Relax more test tolerances
URL: https://github.com/apache/tvm/pull/11152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org