You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "exceptionfactory (via GitHub)" <gi...@apache.org> on 2023/06/14 15:24:55 UTC

[GitHub] [nifi] exceptionfactory opened a new pull request, #7378: NIFI-11689 Add Maven Wrapper with Maven 3.9.2

exceptionfactory opened a new pull request, #7378:
URL: https://github.com/apache/nifi/pull/7378

   # Summary
   
   [NIFI-11689](https://issues.apache.org/jira/browse/NIFI-11689) Adds the [Apache Maven Wrapper](https://maven.apache.org/wrapper/) scripts with Maven 3.9.2 for consistent Maven versioning across build platforms.
   
   Changes include updating GitHub workflows to use Maven Wrapper instead of the available Maven version to ensure the same version of Maven for all platforms.
   
   The Maven Wrapper scripts use the `only-script` option as described in the documentation, which relies on platform commands to download the configured Maven version.
   
   The addition of Maven Wrapper does not interfere with standard Maven installations, but provides the recommended approach for consistent builds.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
     - [X] JDK 11
     - [X] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] markap14 commented on pull request #7378: NIFI-11689 Add Maven Wrapper with Maven 3.9.2

Posted by "markap14 (via GitHub)" <gi...@apache.org>.
markap14 commented on PR #7378:
URL: https://github.com/apache/nifi/pull/7378#issuecomment-1591873892

   Thanks @exceptionfactory this is a good idea to keep things consistent. All Github Actions look healthy. +1 merged to main.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] markap14 merged pull request #7378: NIFI-11689 Add Maven Wrapper with Maven 3.9.2

Posted by "markap14 (via GitHub)" <gi...@apache.org>.
markap14 merged PR #7378:
URL: https://github.com/apache/nifi/pull/7378


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org