You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/11/02 12:01:25 UTC
[GitHub] [skywalking-banyandb] DevPJ9 opened a new pull request, #203: Changes Of Issue #9759
DevPJ9 opened a new pull request, #203:
URL: https://github.com/apache/skywalking-banyandb/pull/203
Added "In" and "Not_In" parsers in index_filter.go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] DevPJ9 commented on pull request #203: Defining "IN" and "NOT IN" APIs in query module. Issue #9759
Posted by GitBox <gi...@apache.org>.
DevPJ9 commented on PR #203:
URL: https://github.com/apache/skywalking-banyandb/pull/203#issuecomment-1300713638
@Superskyyy I have changed the title and description. Please reveiw.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] Superskyyy commented on pull request #203: Changes Of Issue #9759
Posted by GitBox <gi...@apache.org>.
Superskyyy commented on PR #203:
URL: https://github.com/apache/skywalking-banyandb/pull/203#issuecomment-1300509882
It's better to make the PR title more informative than just an issue reference. Try describe what was changed in the actual context.
Then you refer to the issue that you resolve in text body - Closes: #9759. It will automatically close for you once merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] DevPJ9 closed pull request #203: Defining "IN" and "NOT IN" APIs in query module.Fixes apache/skywalking [BanyanDB]#9759
Posted by GitBox <gi...@apache.org>.
DevPJ9 closed pull request #203: Defining "IN" and "NOT IN" APIs in query module.Fixes apache/skywalking [BanyanDB]#9759
URL: https://github.com/apache/skywalking-banyandb/pull/203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] DevPJ9 commented on pull request #203: Changes Of Issue #9759
Posted by GitBox <gi...@apache.org>.
DevPJ9 commented on PR #203:
URL: https://github.com/apache/skywalking-banyandb/pull/203#issuecomment-1300688828
> to make the PR title more informative than just an issue referenc
Thank you @Superskyyy For the information. I am doing the changes you mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily commented on pull request #203: Changes Of Issue #9759
Posted by GitBox <gi...@apache.org>.
hanahmily commented on PR #203:
URL: https://github.com/apache/skywalking-banyandb/pull/203#issuecomment-1300553523
As @Superskyyy mentioned, you should tweak the title and refer to the issue to close it automatically.
I highly recommend that you should make all changes in this PR rather than splitting it into several tiny ones. This strategy helps contributors track changes. That means you could keep pushing more changes Here. Transforming this PR to a "draft" makes more sense.
Once all is ready and checks and tests are passed, you could turn this PR to the reviewable phase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] codecov-commenter commented on pull request #203: Defining "IN" and "NOT IN" APIs in query module. Issue #9759
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #203:
URL: https://github.com/apache/skywalking-banyandb/pull/203#issuecomment-1300779802
# [Codecov](https://codecov.io/gh/apache/skywalking-banyandb/pull/203?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#203](https://codecov.io/gh/apache/skywalking-banyandb/pull/203?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0147fb1) into [main](https://codecov.io/gh/apache/skywalking-banyandb/commit/1edf859d5ba60897395dd20e280c83b9b91c4008?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1edf859) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #203 +/- ##
=======================================
Coverage 44.77% 44.77%
=======================================
Files 84 84
Lines 8355 8355
=======================================
Hits 3741 3741
Misses 4297 4297
Partials 317 317
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily commented on a diff in pull request #203: Changes Of Issue #9759
Posted by GitBox <gi...@apache.org>.
hanahmily commented on code in PR #203:
URL: https://github.com/apache/skywalking-banyandb/pull/203#discussion_r1011840500
##########
pkg/query/logical/index_filter.go:
##########
@@ -146,6 +146,20 @@ func parseCondition(cond *model_v1.Condition, indexRule *database_v1.IndexRule,
and.append(newEq(indexRule, newBytesLiteral(b)))
}
return newNot(indexRule, and), []tsdb.Entity{entity}, nil
+ case model_v1.Condition_BINARY_OP_IN:
+ bb := expr.Bytes()
+ and := newOr(len(bb))
Review Comment:
Renam the variable and other "and" to "or".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] DevPJ9 commented on a diff in pull request #203: Defining "IN" and "NOT IN" APIs in query module. Issue #9759
Posted by GitBox <gi...@apache.org>.
DevPJ9 commented on code in PR #203:
URL: https://github.com/apache/skywalking-banyandb/pull/203#discussion_r1011968203
##########
pkg/query/logical/index_filter.go:
##########
@@ -146,6 +146,20 @@ func parseCondition(cond *model_v1.Condition, indexRule *database_v1.IndexRule,
and.append(newEq(indexRule, newBytesLiteral(b)))
}
return newNot(indexRule, and), []tsdb.Entity{entity}, nil
+ case model_v1.Condition_BINARY_OP_IN:
+ bb := expr.Bytes()
+ and := newOr(len(bb))
Review Comment:
@hanahmily I have done the changes please review and let me know if any changes are needed. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org