You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by Matt Burgess <ma...@gmail.com> on 2015/06/09 04:22:48 UTC

Review Request 35242: DRILL-3199: GenericAccessor doesn't support isNull

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35242/
-----------------------------------------------------------

Review request for drill.


Repository: drill-git


Description
-------

When calling isNull() from a result set, if the method gets delegated/propagated to a GenericAccessor, it throws an UnsupportedOperationException. Since GenericAccessor uses its underlying ValueVector for most other methods, I think it should also delegate the isNull() method and return whatever comes back from the ValueVector.isNull() call.


Diffs
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/GenericAccessor.java 347cf26 
  exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/GenericAccessor.java 347cf26 
  exec/java-exec/src/test/java/org/apache/drill/exec/vector/accessor/GenericAccessorTest.java PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/vector/accessor/GenericAccessorTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/35242/diff/


Testing
-------


Thanks,

Matt Burgess