[GitHub] [openwhisk] rabbah commented on a change in pull request #4593: Change ContainerPool buffer processing

[GitBox <gi...@apache.org>]

rabbah commented on a change in pull request #4593: Change ContainerPool buffer processing 
URL: https://github.com/apache/openwhisk/pull/4593#discussion_r353037591
 
 

 ##########
 File path: core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerPool.scala
 ##########
 @@ -173,7 +173,8 @@ class ContainerPool(childFactory: ActorRefFactory => ActorRef,
               // from the buffer
               val (_, newBuffer) = runBuffer.dequeue
               runBuffer = newBuffer
-              runBuffer.dequeueOption.foreach { case (run, _) => self ! run }
 
 Review comment:
   do you mind fixing this comment on line 170
               // Remove the action that get's executed now from the buffer and execute the next one afterwards.
   to
               // Remove the action that was just executed from the buffer and execute the next one in the queue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services