[GitHub] [celix] xuzhenbao commented on a diff in pull request #495: Add discovery zeroconf for RSA

["xuzhenbao (via GitHub)" <gi...@apache.org>]

xuzhenbao commented on code in PR #495:
URL: https://github.com/apache/celix/pull/495#discussion_r1132606987


##########
bundles/remote_services/rsa_spi/include/remote_constants.h:
##########
@@ -36,4 +36,6 @@ static const char * const OSGI_RSA_SERVICE_IMPORTED_CONFIGS = "service.imported.
 static const char * const OSGI_RSA_SERVICE_EXPORTED_CONFIGS = "service.exported.configs";
 static const char * const OSGI_RSA_SERVICE_LOCATION = "service.location";
 
+static const char * const RSA_DISCOVERY_ZEROCONF_SERVICE_ANNOUNCED_IF_INDEX = "RSA_DZC_IF_INDEX";

Review Comment:
   In a multi-network interface environment, I want RSA to specify to which network interface its service will be published. Without this parameter, DISCOVERY unknow  which network interface to publish the service. If a service is published to all interfaces by default, some clients can discover the service, but may not be able to use it. And there may be security issues (Intranet services can be found through the external network).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org