[jira] [Commented] (VCL-1003) drag and drop support for moving privilege nodes

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/VCL-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15735711#comment-15735711 ] 

ASF subversion and git services commented on VCL-1003:
------------------------------------------------------

Commit 1773427 from [~jfthomps] in branch 'vcl/trunk'
[ https://svn.apache.org/r1773427 ]

VCL-1003 - drag and drop support for moving privilege nodes

privilege.php:
-modified viewNodes: 
  -added global javascript variable nodedropdata
  -added continuation to update nodedropdata
  -added javascript connection for onSet on nodestore
  -added ForestStoreModel between store and tree
  -added a bunch of javascript connections to tree
  -added Undo Move button at bottom of tree
  -changed text written vertically for user, user group, and resource groups to be done via css instead of generating images
  -added move confirmation dialog
  -added revert move confirmation dialog
-modified selectNode:
  -added Undo Move button at bottom of tree
  -changed text written vertically for user, user group, and resource groups to be done via css instead of generating images
  -added javascript to set undo button to be enabled if a move can be undone
-modified JSONprivnodelist2: added parent data to each node
-added nodeDropData
-added AJrefreshNodeDropData
-modified AJsubmitAddChildNode: added $parent as argument to addChildNode
-added AJmoveNode
-added AJsubmitMoveNode
-added AJrevertMoveNode
-modified AJchangeUserPrivs: check if user being modified is logged in user and if nodeAdmin, block, or cascade is being changed, if so, include refreshNodeDropData() in returned javascript
-modified AJchangeUserGroupPrivs: check if user group being modified is one logged in user is a member of and if nodeAdmin, block, or cascade is being changed, if so, include refreshNodeDropData() in returned javascript
-modified AJsubmitAddUserPriv: check if submitted user is logged in user and if nodeAdmin, block, or cascade is being added, if so, include refreshNodeDropData() in returned javascript
-modified AJsubmitAddUserGroupPriv: check if user group being added is one logged in user is a member of and if nodeAdmin, block, or cascade is being added, if so, include refreshNodeDropData() in returned javascript

utils.php:
-removed getImageText
-modified getDojoHTML: added dijit.tree.ForestStoreModel and dijit.tree.dndSource to $dojoRequires for viewNodes; added javascript for dojo.connect for onmouseup to document under case 'viewNodes'

states.php:
-added AJmoveNode
-added AJsubmitMoveNode
-added AJrevertMoveNode
-added AJrefreshNodeDropData

vcl.css:
-added th.privheader
-added th.privheader > div

privilege.js:
-added several globals: saveMoveNode, moveitem, nomove, dragnode, mouseontree, dragging, moveData object
-general changes in several functions:
  -removed some old commented out code
  -reworked how selected node is being displayed as selected, previously this was done by adding and removing the privtreeselected class; now using tree.attr('path') to set and get the selected node (this is the more proper way)
  -changed references to tree.store to refer to tree.model.store since the ForestStoreModel was added between them
-added mouseDown
-added mouseRelease
-modified addChildNode: added parentid as an additional argument; include parentid when calling store.newItem; added call to positionNode so that node gets put in the right sort order in the tree; add an entry to nodedropdata for the new node
-added positionNode
-modified removeNodesFromTree: added code to set the Undo Move button to disabled if the previous parent of the moved node is the one being removed
-modified removeNodesFromTreeCB: wrapped call to deleteItem with setting nomove to 1 and back to 0 so that moveNode just returns when invoked by the call to deleteItem
-modified renameNode: added code to put focus on submitRenameNodeBtn, if enter was used to submit the new name while the focus was on the text box, the new value of the text box was not saved in the widget and the old name was getting submitted; set focus back on text box if the name wasn't actually changed in the text box
-modified renameNodeCB: wrapped setValue with setting nomove to 0 and back to 1 so moveNode just returns when invoked by the call to setValue; added setTimeout to reposition node based on new name after half a second
-added moveNode
-added moveNodeCB
-added submitMoveNode
-added submitMoveNodeCB
-added submitRevertMoveNode
-added submitRevertMoveNodeCB
-added revertNodeMove
-added revertNodeMoveCB
-added setSelected
-added checkCanMove
-added checkNodeDrop
-added refreshNodeDropData

deleted images/textimage.php - changed code calling this to use css to write text vertically

> drag and drop support for moving privilege nodes
> ------------------------------------------------
>
>                 Key: VCL-1003
>                 URL: https://issues.apache.org/jira/browse/VCL-1003
>             Project: VCL
>          Issue Type: New Feature
>          Components: web gui (frontend)
>            Reporter: Josh Thompson
>
> Being able to drag and drop privilege nodes to reorganize things would be helpful. Drag and drop is supported by the Dijit tree widget being used for the privilege tree. So, the proper hooks just need to be added with supporting php functions to update the database.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)