[GitHub] [incubator-superset] graceguo-supercat edited a comment on issue #8733: Replace pandas.DataFrame with PyArrow.Table for nullable int typing

[GitBox <gi...@apache.org>]

graceguo-supercat edited a comment on issue #8733: Replace pandas.DataFrame with PyArrow.Table for nullable int typing
URL: https://github.com/apache/incubator-superset/pull/8733#issuecomment-572317193
 
 
   Hi @robdiciuccio I am trying to deploy this feature to airbnb production. But I got many errors from **Presto** queries: 
   `Unserializable object ['silver.braavos_staging.revenue_validation_detail_metrics'] of type <class 'numpy.ndarray'>`
   or
   `Not implemented type for list in DataFrameBlock: struct<author_type: string, locale: string>`
   
   The full stack trace:
   ```
   Traceback (most recent call last):
     File "/usr/local/lib/python3.6/dist-packages/flask/app.py", line 2463, in __call__
       return self.wsgi_app(environ, start_response)
     File "/usr/local/lib/python3.6/dist-packages/flask/app.py", line 2449, in wsgi_app
       response = self.handle_exception(e)
     File "/usr/local/lib/python3.6/dist-packages/flask/app.py", line 1866, in handle_exception
       reraise(exc_type, exc_value, tb)
     File "/usr/local/lib/python3.6/dist-packages/flask/_compat.py", line 39, in reraise
       raise value
     File "/usr/local/lib/python3.6/dist-packages/flask/app.py", line 2446, in wsgi_app
       response = self.full_dispatch_request()
     File "/usr/local/lib/python3.6/dist-packages/flask/app.py", line 1951, in full_dispatch_request
       rv = self.handle_user_exception(e)
     File "/usr/local/lib/python3.6/dist-packages/flask/app.py", line 1820, in handle_user_exception
       reraise(exc_type, exc_value, tb)
     File "/usr/local/lib/python3.6/dist-packages/flask/_compat.py", line 39, in reraise
       raise value
     File "/usr/local/lib/python3.6/dist-packages/flask/app.py", line 1949, in full_dispatch_request
       rv = self.dispatch_request()
     File "/usr/local/lib/python3.6/dist-packages/flask/app.py", line 1935, in dispatch_request
       return self.view_functions[rule.endpoint](**req.view_args)
     File "/usr/local/lib/python3.6/dist-packages/flask_appbuilder/security/decorators.py", line 168, in wraps
       return f(self, *args, **kwargs)
     File "/home/grace_guo/incubator-superset/superset/utils/log.py", line 59, in wrapper
       value = f(*args, **kwargs)
     File "/home/grace_guo/incubator-superset/superset/views/core.py", line 2291, in results
       return self.results_exec(key)
     File "/home/grace_guo/incubator-superset/superset/views/core.py", line 2342, in results_exec
       json.dumps(obj, default=utils.json_iso_dttm_ser, ignore_nan=True)
     File "/usr/local/lib/python3.6/dist-packages/simplejson/__init__.py", line 399, in dumps
       **kw).encode(obj)
     File "/usr/local/lib/python3.6/dist-packages/simplejson/encoder.py", line 296, in encode
       chunks = self.iterencode(o, _one_shot=True)
     File "/usr/local/lib/python3.6/dist-packages/simplejson/encoder.py", line 378, in iterencode
       return _iterencode(o, 0)
     File "/home/grace_guo/incubator-superset/superset/utils/core.py", line 383, in json_iso_dttm_ser
       "Unserializable object {} of type {}".format(obj, type(obj))
   TypeError: Unserializable object ['silver.information_schema.tables'] of type <class 'numpy.ndarray'>
   ```
   
   So i have to revert this feature from airbnb's release branch. Please take a look. We should also consider revert this PR from master branch.
   
   @mistercrunch @willbarrett 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org