You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/17 12:13:15 UTC
[GitHub] [arrow] alamb opened a new pull request #7980: ARROW-9768 [Rust] [DataFusion] Rename PhysicalPlannerImpl to DefaultPhysicalPlanner
alamb opened a new pull request #7980:
URL: https://github.com/apache/arrow/pull/7980
Proposed follow up to https://github.com/apache/arrow/pull/7975 -- rename `PhysicalPlannerImpl` to `DefaultPhysicalPlanner` to better describe what it is and that the design allows for more than one.
I considered a more specific name like `SingleNodeMultiThreadedPlanner` but I felt a lot of that was a function of the Physical nodes that got created rather than the planner itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7980: ARROW-9768 [Rust] [DataFusion] Rename PhysicalPlannerImpl to DefaultPhysicalPlanner
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7980:
URL: https://github.com/apache/arrow/pull/7980#issuecomment-674850748
https://issues.apache.org/jira/browse/ARROW-9768
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove commented on a change in pull request #7980: ARROW-9768 [Rust] [DataFusion] Rename PhysicalPlannerImpl to DefaultPhysicalPlanner
Posted by GitBox <gi...@apache.org>.
andygrove commented on a change in pull request #7980:
URL: https://github.com/apache/arrow/pull/7980#discussion_r471502392
##########
File path: rust/datafusion/src/execution/physical_plan/mod.rs
##########
@@ -33,7 +33,8 @@ use arrow::{
};
use udf::ScalarFunction;
-/// Physical query planner
+/// Physical query planner that converts a `LogicalPlan` to an
+/// `ExecutionPlan` suitable for execution.
Review comment:
Note that in the rustdoc format we can actually link to other items. e.g. `[ExecutionPlan](trait.ExecutionPlan.html)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove closed pull request #7980: ARROW-9768 [Rust] [DataFusion] Rename PhysicalPlannerImpl to DefaultPhysicalPlanner
Posted by GitBox <gi...@apache.org>.
andygrove closed pull request #7980:
URL: https://github.com/apache/arrow/pull/7980
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org