You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by su...@apache.org on 2022/11/09 03:06:26 UTC
[shardingsphere] branch master updated: Restructure DynamicLoadingSQLParserParameterizedTest for Strategy (#22024)
This is an automated email from the ASF dual-hosted git repository.
sunnianjun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 521067c77f0 Restructure DynamicLoadingSQLParserParameterizedTest for Strategy (#22024)
521067c77f0 is described below
commit 521067c77f0a290c50c1fc6d9fd5e0aaa1bccd83
Author: Junfeng <i...@jacob953.com>
AuthorDate: Wed Nov 9 11:06:16 2022 +0800
Restructure DynamicLoadingSQLParserParameterizedTest for Strategy (#22024)
* feat: convert private to protact & rename Api with API
Co-authored-by: Jacob953 <ja...@csu.edu.cn>
---
.../base/DynamicLoadingSQLParserParameterizedTest.java | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/test/integration-test/sql-parser/src/test/java/org/apache/shardingsphere/sql/parser/base/DynamicLoadingSQLParserParameterizedTest.java b/test/integration-test/sql-parser/src/test/java/org/apache/shardingsphere/sql/parser/base/DynamicLoadingSQLParserParameterizedTest.java
index 24602212a99..b7c3439b33a 100644
--- a/test/integration-test/sql-parser/src/test/java/org/apache/shardingsphere/sql/parser/base/DynamicLoadingSQLParserParameterizedTest.java
+++ b/test/integration-test/sql-parser/src/test/java/org/apache/shardingsphere/sql/parser/base/DynamicLoadingSQLParserParameterizedTest.java
@@ -71,10 +71,10 @@ public abstract class DynamicLoadingSQLParserParameterizedTest {
return result;
}
- private static Collection<Map<String, String>> getResponse(final String sqlCaseApi, final URI sqlCaseURI) {
+ protected static Collection<Map<String, String>> getResponse(final String sqlCaseAPI, final URI sqlCaseURI) {
Collection<Map<String, String>> result = new LinkedList<>();
- URI casesURI = getApiURL(sqlCaseApi, sqlCaseURI);
- String caseContent = getContent(casesURI);
+ URI casesAPI = getAPI(sqlCaseAPI, sqlCaseURI);
+ String caseContent = getContent(casesAPI);
if (caseContent.isEmpty()) {
return result;
}
@@ -87,21 +87,21 @@ public abstract class DynamicLoadingSQLParserParameterizedTest {
if (eachName.endsWith(".sql") || eachName.endsWith(".test")) {
result.add(ImmutableMap.of("name", eachName, "download_url", casesDownloadURL.get(each)));
} else if (!eachName.contains(".")) {
- result.addAll(getResponse(sqlCaseApi, URI.create(casesHtmlURL.get(each))));
+ result.addAll(getResponse(sqlCaseAPI, URI.create(casesHtmlURL.get(each))));
}
});
return result;
}
- private static URI getApiURL(final String sqlCaseApi, final URI sqlCaseURI) {
+ private static URI getAPI(final String sqlCaseAPI, final URI sqlCaseURI) {
String[] patches = sqlCaseURI.toString().split("/", 8);
String casesOwner = patches[3];
String casesRepo = patches[4];
String casesDirectory = patches[7];
- return URI.create(sqlCaseApi + casesOwner + "/" + casesRepo + "/contents/" + casesDirectory);
+ return URI.create(sqlCaseAPI + casesOwner + "/" + casesRepo + "/contents/" + casesDirectory);
}
- private static String getContent(final URI casesURI) {
+ protected static String getContent(final URI casesURI) {
String result = "";
try {
InputStreamReader in = new InputStreamReader(casesURI.toURL().openStream());
@@ -112,7 +112,7 @@ public abstract class DynamicLoadingSQLParserParameterizedTest {
return result;
}
- private static Collection<Object[]> getSQLCases(final String sqlCaseFileName, final String sqlCaseFileContent, final String databaseType) {
+ protected static Collection<Object[]> getSQLCases(final String sqlCaseFileName, final String sqlCaseFileContent, final String databaseType) {
Collection<Object[]> result = new LinkedList<>();
String[] lines = sqlCaseFileContent.split("\n");
int sqlCaseEnum = 1;