You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/21 13:13:43 UTC
[GitHub] [flink] Myasuka opened a new pull request #12282: [FLINK-17865][checkpoint] Increase default size of 'state.backend.fs.memory-threshold'
Myasuka opened a new pull request #12282:
URL: https://github.com/apache/flink/pull/12282
## What is the purpose of the change
Increase the default value of `state.backend.fs.memory-threshold` from `1K` to `20K` as [thread](https://s.apache.org/us0en) discussed.
## Brief change log
- Increase default size of 'state.backend.fs.memory-threshold' from `1k` to `20k`
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: yes
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] StephanEwen commented on pull request #12282: [FLINK-17865][checkpoint] Increase default size of 'state.backend.fs.memory-threshold'
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on pull request #12282:
URL: https://github.com/apache/flink/pull/12282#issuecomment-633874729
Looks good to me, +1 to merge this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12282: [FLINK-17865][checkpoint] Increase default size of 'state.backend.fs.memory-threshold'
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12282:
URL: https://github.com/apache/flink/pull/12282#issuecomment-632089755
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "67bc5db95d319972e8a27f9de71b5edd9c457287",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2006",
"triggerID" : "67bc5db95d319972e8a27f9de71b5edd9c457287",
"triggerType" : "PUSH"
}, {
"hash" : "09833d3d171cfdd17286f53d7917df6bbfe8a8c8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "09833d3d171cfdd17286f53d7917df6bbfe8a8c8",
"triggerType" : "PUSH"
}, {
"hash" : "3cc09ea7ebbfc658371206c1369aba9f061cca49",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2028",
"triggerID" : "3cc09ea7ebbfc658371206c1369aba9f061cca49",
"triggerType" : "PUSH"
}, {
"hash" : "81a8f34c3108c7efc0ed350a50b59c2829a99eff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2030",
"triggerID" : "81a8f34c3108c7efc0ed350a50b59c2829a99eff",
"triggerType" : "PUSH"
}, {
"hash" : "55c8d2883eca542317e3cbfd3786d4c226f43305",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2032",
"triggerID" : "55c8d2883eca542317e3cbfd3786d4c226f43305",
"triggerType" : "PUSH"
}, {
"hash" : "adda0dd7029004ef970b7bb8a8e06ba08b167781",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2040",
"triggerID" : "adda0dd7029004ef970b7bb8a8e06ba08b167781",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 09833d3d171cfdd17286f53d7917df6bbfe8a8c8 UNKNOWN
* adda0dd7029004ef970b7bb8a8e06ba08b167781 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2040)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on pull request #12282: [FLINK-17865][checkpoint] Increase default size of 'state.backend.fs.memory-threshold'
Posted by GitBox <gi...@apache.org>.
Myasuka commented on pull request #12282:
URL: https://github.com/apache/flink/pull/12282#issuecomment-633393969
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12282: [FLINK-17865][checkpoint] Increase default size of 'state.backend.fs.memory-threshold'
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12282:
URL: https://github.com/apache/flink/pull/12282#issuecomment-632079473
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 67bc5db95d319972e8a27f9de71b5edd9c457287 (Thu May 21 13:15:22 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12282: [FLINK-17865][checkpoint] Increase default size of 'state.backend.fs.memory-threshold'
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12282:
URL: https://github.com/apache/flink/pull/12282#issuecomment-632089755
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12282: [FLINK-17865][checkpoint] Increase default size of 'state.backend.fs.memory-threshold'
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12282:
URL: https://github.com/apache/flink/pull/12282#issuecomment-632089755
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "67bc5db95d319972e8a27f9de71b5edd9c457287",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2006",
"triggerID" : "67bc5db95d319972e8a27f9de71b5edd9c457287",
"triggerType" : "PUSH"
}, {
"hash" : "09833d3d171cfdd17286f53d7917df6bbfe8a8c8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "09833d3d171cfdd17286f53d7917df6bbfe8a8c8",
"triggerType" : "PUSH"
}, {
"hash" : "3cc09ea7ebbfc658371206c1369aba9f061cca49",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2028",
"triggerID" : "3cc09ea7ebbfc658371206c1369aba9f061cca49",
"triggerType" : "PUSH"
}, {
"hash" : "81a8f34c3108c7efc0ed350a50b59c2829a99eff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2030",
"triggerID" : "81a8f34c3108c7efc0ed350a50b59c2829a99eff",
"triggerType" : "PUSH"
}, {
"hash" : "55c8d2883eca542317e3cbfd3786d4c226f43305",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2032",
"triggerID" : "55c8d2883eca542317e3cbfd3786d4c226f43305",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 09833d3d171cfdd17286f53d7917df6bbfe8a8c8 UNKNOWN
* 55c8d2883eca542317e3cbfd3786d4c226f43305 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2032)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] klion26 commented on a change in pull request #12282: [FLINK-17865][checkpoint] Increase default size of 'state.backend.fs.memory-threshold'
Posted by GitBox <gi...@apache.org>.
klion26 commented on a change in pull request #12282:
URL: https://github.com/apache/flink/pull/12282#discussion_r429638795
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendLoadingTest.java
##########
@@ -227,7 +228,7 @@ public void testLoadFileSystemStateBackend() throws Exception {
final String savepointDir = new Path(tmp.newFolder().toURI()).toString();
final Path expectedCheckpointsPath = new Path(checkpointDir);
final Path expectedSavepointsPath = new Path(savepointDir);
- final int threshold = 1000000;
+ final MemorySize threshold = MemorySize.parse("900kb");
Review comment:
Do you think we need to add a test case to verify the default value of `state.backend.fs.memory-threshold`(do not set this key, and verify the result of `getMinFileSizeThreshold()` is the expected value)
##########
File path: docs/_includes/generated/checkpointing_configuration.html
##########
@@ -22,9 +22,9 @@
</tr>
<tr>
<td><h5>state.backend.fs.memory-threshold</h5></td>
- <td style="word-wrap: break-word;">1024</td>
- <td>Integer</td>
- <td>The minimum size of state data files. All state chunks smaller than that are stored inline in the root checkpoint metadata file.</td>
+ <td style="word-wrap: break-word;">20 kb</td>
+ <td>MemorySize</td>
+ <td>The minimum size of state data files. All state chunks smaller than that are stored inline in the root checkpoint metadata file. The max memory threshold for this configuration is 1MB.</td>
Review comment:
Good to add the upper limit here :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12282: [FLINK-17865][checkpoint] Increase default size of 'state.backend.fs.memory-threshold'
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12282:
URL: https://github.com/apache/flink/pull/12282#issuecomment-632089755
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "67bc5db95d319972e8a27f9de71b5edd9c457287",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2006",
"triggerID" : "67bc5db95d319972e8a27f9de71b5edd9c457287",
"triggerType" : "PUSH"
}, {
"hash" : "09833d3d171cfdd17286f53d7917df6bbfe8a8c8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "09833d3d171cfdd17286f53d7917df6bbfe8a8c8",
"triggerType" : "PUSH"
}, {
"hash" : "3cc09ea7ebbfc658371206c1369aba9f061cca49",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2028",
"triggerID" : "3cc09ea7ebbfc658371206c1369aba9f061cca49",
"triggerType" : "PUSH"
}, {
"hash" : "81a8f34c3108c7efc0ed350a50b59c2829a99eff",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2030",
"triggerID" : "81a8f34c3108c7efc0ed350a50b59c2829a99eff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 09833d3d171cfdd17286f53d7917df6bbfe8a8c8 UNKNOWN
* 81a8f34c3108c7efc0ed350a50b59c2829a99eff Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2030)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12282: [FLINK-17865][checkpoint] Increase default size of 'state.backend.fs.memory-threshold'
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12282:
URL: https://github.com/apache/flink/pull/12282#issuecomment-632089755
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "67bc5db95d319972e8a27f9de71b5edd9c457287",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2006",
"triggerID" : "67bc5db95d319972e8a27f9de71b5edd9c457287",
"triggerType" : "PUSH"
}, {
"hash" : "09833d3d171cfdd17286f53d7917df6bbfe8a8c8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "09833d3d171cfdd17286f53d7917df6bbfe8a8c8",
"triggerType" : "PUSH"
}, {
"hash" : "3cc09ea7ebbfc658371206c1369aba9f061cca49",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2028",
"triggerID" : "3cc09ea7ebbfc658371206c1369aba9f061cca49",
"triggerType" : "PUSH"
}, {
"hash" : "81a8f34c3108c7efc0ed350a50b59c2829a99eff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2030",
"triggerID" : "81a8f34c3108c7efc0ed350a50b59c2829a99eff",
"triggerType" : "PUSH"
}, {
"hash" : "55c8d2883eca542317e3cbfd3786d4c226f43305",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2032",
"triggerID" : "55c8d2883eca542317e3cbfd3786d4c226f43305",
"triggerType" : "PUSH"
}, {
"hash" : "adda0dd7029004ef970b7bb8a8e06ba08b167781",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2040",
"triggerID" : "adda0dd7029004ef970b7bb8a8e06ba08b167781",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 09833d3d171cfdd17286f53d7917df6bbfe8a8c8 UNKNOWN
* 55c8d2883eca542317e3cbfd3786d4c226f43305 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2032)
* adda0dd7029004ef970b7bb8a8e06ba08b167781 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2040)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12282: [FLINK-17865][checkpoint] Increase default size of 'state.backend.fs.memory-threshold'
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12282:
URL: https://github.com/apache/flink/pull/12282#issuecomment-632089755
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "67bc5db95d319972e8a27f9de71b5edd9c457287",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2006",
"triggerID" : "67bc5db95d319972e8a27f9de71b5edd9c457287",
"triggerType" : "PUSH"
}, {
"hash" : "09833d3d171cfdd17286f53d7917df6bbfe8a8c8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "09833d3d171cfdd17286f53d7917df6bbfe8a8c8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 67bc5db95d319972e8a27f9de71b5edd9c457287 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2006)
* 09833d3d171cfdd17286f53d7917df6bbfe8a8c8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12282: [FLINK-17865][checkpoint] Increase default size of 'state.backend.fs.memory-threshold'
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12282:
URL: https://github.com/apache/flink/pull/12282#issuecomment-632089755
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "67bc5db95d319972e8a27f9de71b5edd9c457287",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2006",
"triggerID" : "67bc5db95d319972e8a27f9de71b5edd9c457287",
"triggerType" : "PUSH"
}, {
"hash" : "09833d3d171cfdd17286f53d7917df6bbfe8a8c8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "09833d3d171cfdd17286f53d7917df6bbfe8a8c8",
"triggerType" : "PUSH"
}, {
"hash" : "3cc09ea7ebbfc658371206c1369aba9f061cca49",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3cc09ea7ebbfc658371206c1369aba9f061cca49",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 67bc5db95d319972e8a27f9de71b5edd9c457287 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2006)
* 09833d3d171cfdd17286f53d7917df6bbfe8a8c8 UNKNOWN
* 3cc09ea7ebbfc658371206c1369aba9f061cca49 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12282: [FLINK-17865][checkpoint] Increase default size of 'state.backend.fs.memory-threshold'
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12282:
URL: https://github.com/apache/flink/pull/12282#issuecomment-632089755
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "67bc5db95d319972e8a27f9de71b5edd9c457287",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2006",
"triggerID" : "67bc5db95d319972e8a27f9de71b5edd9c457287",
"triggerType" : "PUSH"
}, {
"hash" : "09833d3d171cfdd17286f53d7917df6bbfe8a8c8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "09833d3d171cfdd17286f53d7917df6bbfe8a8c8",
"triggerType" : "PUSH"
}, {
"hash" : "3cc09ea7ebbfc658371206c1369aba9f061cca49",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2028",
"triggerID" : "3cc09ea7ebbfc658371206c1369aba9f061cca49",
"triggerType" : "PUSH"
}, {
"hash" : "81a8f34c3108c7efc0ed350a50b59c2829a99eff",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2030",
"triggerID" : "81a8f34c3108c7efc0ed350a50b59c2829a99eff",
"triggerType" : "PUSH"
}, {
"hash" : "55c8d2883eca542317e3cbfd3786d4c226f43305",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "55c8d2883eca542317e3cbfd3786d4c226f43305",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 09833d3d171cfdd17286f53d7917df6bbfe8a8c8 UNKNOWN
* 81a8f34c3108c7efc0ed350a50b59c2829a99eff Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2030)
* 55c8d2883eca542317e3cbfd3786d4c226f43305 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12282: [FLINK-17865][checkpoint] Increase default size of 'state.backend.fs.memory-threshold'
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12282:
URL: https://github.com/apache/flink/pull/12282#issuecomment-632089755
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "67bc5db95d319972e8a27f9de71b5edd9c457287",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2006",
"triggerID" : "67bc5db95d319972e8a27f9de71b5edd9c457287",
"triggerType" : "PUSH"
}, {
"hash" : "09833d3d171cfdd17286f53d7917df6bbfe8a8c8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "09833d3d171cfdd17286f53d7917df6bbfe8a8c8",
"triggerType" : "PUSH"
}, {
"hash" : "3cc09ea7ebbfc658371206c1369aba9f061cca49",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2028",
"triggerID" : "3cc09ea7ebbfc658371206c1369aba9f061cca49",
"triggerType" : "PUSH"
}, {
"hash" : "81a8f34c3108c7efc0ed350a50b59c2829a99eff",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "81a8f34c3108c7efc0ed350a50b59c2829a99eff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 09833d3d171cfdd17286f53d7917df6bbfe8a8c8 UNKNOWN
* 3cc09ea7ebbfc658371206c1369aba9f061cca49 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2028)
* 81a8f34c3108c7efc0ed350a50b59c2829a99eff UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] carp84 closed pull request #12282: [FLINK-17865][checkpoint] Increase default size of 'state.backend.fs.memory-threshold'
Posted by GitBox <gi...@apache.org>.
carp84 closed pull request #12282:
URL: https://github.com/apache/flink/pull/12282
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12282: [FLINK-17865][checkpoint] Increase default size of 'state.backend.fs.memory-threshold'
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12282:
URL: https://github.com/apache/flink/pull/12282#issuecomment-632089755
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "67bc5db95d319972e8a27f9de71b5edd9c457287",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2006",
"triggerID" : "67bc5db95d319972e8a27f9de71b5edd9c457287",
"triggerType" : "PUSH"
}, {
"hash" : "09833d3d171cfdd17286f53d7917df6bbfe8a8c8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "09833d3d171cfdd17286f53d7917df6bbfe8a8c8",
"triggerType" : "PUSH"
}, {
"hash" : "3cc09ea7ebbfc658371206c1369aba9f061cca49",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2028",
"triggerID" : "3cc09ea7ebbfc658371206c1369aba9f061cca49",
"triggerType" : "PUSH"
}, {
"hash" : "81a8f34c3108c7efc0ed350a50b59c2829a99eff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2030",
"triggerID" : "81a8f34c3108c7efc0ed350a50b59c2829a99eff",
"triggerType" : "PUSH"
}, {
"hash" : "55c8d2883eca542317e3cbfd3786d4c226f43305",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2032",
"triggerID" : "55c8d2883eca542317e3cbfd3786d4c226f43305",
"triggerType" : "PUSH"
}, {
"hash" : "adda0dd7029004ef970b7bb8a8e06ba08b167781",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "adda0dd7029004ef970b7bb8a8e06ba08b167781",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 09833d3d171cfdd17286f53d7917df6bbfe8a8c8 UNKNOWN
* 55c8d2883eca542317e3cbfd3786d4c226f43305 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2032)
* adda0dd7029004ef970b7bb8a8e06ba08b167781 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] StephanEwen commented on a change in pull request #12282: [FLINK-17865][checkpoint] Increase default size of 'state.backend.fs.memory-threshold'
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on a change in pull request #12282:
URL: https://github.com/apache/flink/pull/12282#discussion_r429804977
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsStateBackend.java
##########
@@ -388,6 +388,10 @@ private FsStateBackend(FsStateBackend original, ReadableConfig configuration, Cl
this.writeBufferSize = Math.max(bufferSize, this.fileStateThreshold);
}
+ private boolean checkFileSateThresholdValid(int fileStateThreshold) {
Review comment:
Typo in this method name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] carp84 commented on pull request #12282: [FLINK-17865][checkpoint] Increase default size of 'state.backend.fs.memory-threshold'
Posted by GitBox <gi...@apache.org>.
carp84 commented on pull request #12282:
URL: https://github.com/apache/flink/pull/12282#issuecomment-635498231
The e2e tests (#12373) for release-1.11 passed thus I will merge the changes. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12282: [FLINK-17865][checkpoint] Increase default size of 'state.backend.fs.memory-threshold'
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12282:
URL: https://github.com/apache/flink/pull/12282#issuecomment-632089755
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "67bc5db95d319972e8a27f9de71b5edd9c457287",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2006",
"triggerID" : "67bc5db95d319972e8a27f9de71b5edd9c457287",
"triggerType" : "PUSH"
}, {
"hash" : "09833d3d171cfdd17286f53d7917df6bbfe8a8c8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "09833d3d171cfdd17286f53d7917df6bbfe8a8c8",
"triggerType" : "PUSH"
}, {
"hash" : "3cc09ea7ebbfc658371206c1369aba9f061cca49",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2028",
"triggerID" : "3cc09ea7ebbfc658371206c1369aba9f061cca49",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 09833d3d171cfdd17286f53d7917df6bbfe8a8c8 UNKNOWN
* 3cc09ea7ebbfc658371206c1369aba9f061cca49 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2028)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on pull request #12282: [FLINK-17865][checkpoint] Increase default size of 'state.backend.fs.memory-threshold'
Posted by GitBox <gi...@apache.org>.
Myasuka commented on pull request #12282:
URL: https://github.com/apache/flink/pull/12282#issuecomment-632978514
My azure CI pipeline has run successfully twice: [my-build-1](https://myasuka.visualstudio.com/flink/_build/results?buildId=77) and [my-build-2](https://myasuka.visualstudio.com/flink/_build/results?buildId=75)
Current CI in this PR failed due to FLINK-16572
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12282: [FLINK-17865][checkpoint] Increase default size of 'state.backend.fs.memory-threshold'
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12282:
URL: https://github.com/apache/flink/pull/12282#issuecomment-632089755
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "67bc5db95d319972e8a27f9de71b5edd9c457287",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2006",
"triggerID" : "67bc5db95d319972e8a27f9de71b5edd9c457287",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 67bc5db95d319972e8a27f9de71b5edd9c457287 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2006)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on a change in pull request #12282: [FLINK-17865][checkpoint] Increase default size of 'state.backend.fs.memory-threshold'
Posted by GitBox <gi...@apache.org>.
Myasuka commented on a change in pull request #12282:
URL: https://github.com/apache/flink/pull/12282#discussion_r429976396
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendLoadingTest.java
##########
@@ -227,7 +228,7 @@ public void testLoadFileSystemStateBackend() throws Exception {
final String savepointDir = new Path(tmp.newFolder().toURI()).toString();
final Path expectedCheckpointsPath = new Path(checkpointDir);
final Path expectedSavepointsPath = new Path(savepointDir);
- final int threshold = 1000000;
+ final MemorySize threshold = MemorySize.parse("900kb");
Review comment:
I think current [test_get_min_file_size_threshold](https://github.com/apache/flink/blob/e92b2bf19bdf03ad3bae906dc5fa3781aeddb3ee/flink-python/pyflink/datastream/tests/test_state_backend.py#L100) should already verify it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12282: [FLINK-17865][checkpoint] Increase default size of 'state.backend.fs.memory-threshold'
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12282:
URL: https://github.com/apache/flink/pull/12282#issuecomment-632089755
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "67bc5db95d319972e8a27f9de71b5edd9c457287",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2006",
"triggerID" : "67bc5db95d319972e8a27f9de71b5edd9c457287",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 67bc5db95d319972e8a27f9de71b5edd9c457287 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2006)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12282: [FLINK-17865][checkpoint] Increase default size of 'state.backend.fs.memory-threshold'
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12282:
URL: https://github.com/apache/flink/pull/12282#issuecomment-632089755
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "67bc5db95d319972e8a27f9de71b5edd9c457287",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "67bc5db95d319972e8a27f9de71b5edd9c457287",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 67bc5db95d319972e8a27f9de71b5edd9c457287 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12282: [FLINK-17865][checkpoint] Increase default size of 'state.backend.fs.memory-threshold'
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12282:
URL: https://github.com/apache/flink/pull/12282#issuecomment-632089755
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "67bc5db95d319972e8a27f9de71b5edd9c457287",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2006",
"triggerID" : "67bc5db95d319972e8a27f9de71b5edd9c457287",
"triggerType" : "PUSH"
}, {
"hash" : "09833d3d171cfdd17286f53d7917df6bbfe8a8c8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "09833d3d171cfdd17286f53d7917df6bbfe8a8c8",
"triggerType" : "PUSH"
}, {
"hash" : "3cc09ea7ebbfc658371206c1369aba9f061cca49",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2028",
"triggerID" : "3cc09ea7ebbfc658371206c1369aba9f061cca49",
"triggerType" : "PUSH"
}, {
"hash" : "81a8f34c3108c7efc0ed350a50b59c2829a99eff",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2030",
"triggerID" : "81a8f34c3108c7efc0ed350a50b59c2829a99eff",
"triggerType" : "PUSH"
}, {
"hash" : "55c8d2883eca542317e3cbfd3786d4c226f43305",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2032",
"triggerID" : "55c8d2883eca542317e3cbfd3786d4c226f43305",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 09833d3d171cfdd17286f53d7917df6bbfe8a8c8 UNKNOWN
* 81a8f34c3108c7efc0ed350a50b59c2829a99eff Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2030)
* 55c8d2883eca542317e3cbfd3786d4c226f43305 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2032)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org