You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Julian Hyde (Jira)" <ji...@apache.org> on 2020/09/04 19:44:00 UTC

[jira] [Resolved] (CALCITE-4220) In SqlToRelConverter, use RelBuilder for creating Aggregate

     [ https://issues.apache.org/jira/browse/CALCITE-4220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Hyde resolved CALCITE-4220.
----------------------------------
    Fix Version/s: 1.26.0
       Resolution: Fixed

Fixed in [76f26b83|https://github.com/apache/calcite/commit/76f26b8319e66c30c6cbfdfba6d5b2839cdedfa2].

> In SqlToRelConverter, use RelBuilder for creating Aggregate
> -----------------------------------------------------------
>
>                 Key: CALCITE-4220
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4220
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Julian Hyde
>            Assignee: Julian Hyde
>            Priority: Major
>             Fix For: 1.26.0
>
>
> In {{SqlToRelConverter}} use {{RelBuilder}} for creating {{Aggregate}}. Currently we call LogicalAggregate.create directly, and that misses some optimizations.
> Add config option {{RelBuilder.Config.aggregateUnique()}} to disable the optimization that we don't create an {{Aggregate}} if the input is already unique on the GROUP BY key. Without it, some tests in {{SqlToRelConverterTest}} become trivial.
> Also, that optimization is not valid if there are multiple group sets. (Because we should output multiple rows, and Project only returns one.) So disable it in that case.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)