You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/12/21 00:53:49 UTC

[GitHub] [druid] vogievetsky opened a new pull request #12085: Web console: new Ace, diff view, and cleanup. Decorating the console for the holidays ✨ 🎁

vogievetsky opened a new pull request #12085:
URL: https://github.com/apache/druid/pull/12085


   At a high level this PR adds a DiffDialog to visualize the change in supervisor specs between edits. This PR also upgrades the [Ace editor](https://ace.c9.io/) (the main code editor for all the JSONs and SQLs). This is done by upgrading to the latest version or `react-ace` which in turn changes how the Ace editor itself is imported from using `brace` to using `ace-builds` (see the [readme of react-ace](https://github.com/securingsincity/react-ace) for more details on why).
   
   New Diff view:
   
   ![image](https://user-images.githubusercontent.com/177816/146850894-3497dcb7-c175-4aec-977c-9a1f2f0cff59.png)
   
   Updated auto suggestion styling to be more on brand:
   
   ![image](https://user-images.githubusercontent.com/177816/146850974-8a0f92bc-2a75-4c76-8e23-21d721f6b2d0.png)
   
   So here are the changes that generate the diffs:
   
   - Switched from `brace` to `ace-builds` which generates a large number of dependent package and license changes
   - Updated to new ReactAce and went everywhere updating the APIs (there are many changes on the JS and the CSS endpoints)
   - Normalized the capitalization and spelling of all the `describe` labels
   - Pulled out all the Ace editor styles into a single file `ace.scss`
   
   This PR has:
   - [x] been self-reviewed.
   - [x] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] FrankChen021 commented on pull request #12085: Web console: new Ace, diff view, and cleanup. Decorating the console for the holidays ✨ 🎁

Posted by GitBox <gi...@apache.org>.
FrankChen021 commented on pull request #12085:
URL: https://github.com/apache/druid/pull/12085#issuecomment-998394350


   Do we need to handle the HTML tags in the function description?
   
   ![image](https://user-images.githubusercontent.com/6525742/146854986-00b52f80-b75a-465b-a193-27a27195a75f.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] vogievetsky commented on pull request #12085: Web console: new Ace, diff view, and cleanup. Decorating the console for the holidays ✨ 🎁

Posted by GitBox <gi...@apache.org>.
vogievetsky commented on pull request #12085:
URL: https://github.com/apache/druid/pull/12085#issuecomment-999198154


   Just realized that I updated the description with a screenshot for a different function than the one we were talking about, so here it is also:
   
   ![image](https://user-images.githubusercontent.com/177816/147016731-6fffc2a8-8f2b-4ae7-992c-0cfe89283e96.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] vogievetsky commented on pull request #12085: Web console: new Ace, diff view, and cleanup. Decorating the console for the holidays ✨ 🎁

Posted by GitBox <gi...@apache.org>.
vogievetsky commented on pull request #12085:
URL: https://github.com/apache/druid/pull/12085#issuecomment-998476082


   This is even a bug on master!
   
   ![image](https://user-images.githubusercontent.com/177816/146874546-499a15dd-df49-434f-a436-aa778fa483da.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] vogievetsky commented on pull request #12085: Web console: new Ace, diff view, and cleanup. Decorating the console for the holidays ✨ 🎁

Posted by GitBox <gi...@apache.org>.
vogievetsky commented on pull request #12085:
URL: https://github.com/apache/druid/pull/12085#issuecomment-998475204


   Great catch!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] vogievetsky commented on pull request #12085: Web console: new Ace, diff view, and cleanup. Decorating the console for the holidays ✨ 🎁

Posted by GitBox <gi...@apache.org>.
vogievetsky commented on pull request #12085:
URL: https://github.com/apache/druid/pull/12085#issuecomment-999162806


   Fixed and updated the screenshot in the description 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] vogievetsky merged pull request #12085: Web console: new Ace, diff view, and cleanup. Decorating the console for the holidays ✨ 🎁

Posted by GitBox <gi...@apache.org>.
vogievetsky merged pull request #12085:
URL: https://github.com/apache/druid/pull/12085


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org