You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/03/23 21:23:14 UTC
[GitHub] [activemq-nms-openwire] michaelandrepearce opened a new pull request #14: AMQNET-572 - Fix for NMS failover/TLS bug, by saving an Ssl context
michaelandrepearce opened a new pull request #14:
URL: https://github.com/apache/activemq-nms-openwire/pull/14
Note this is simply a sort out of the PR https://github.com/apache/activemq-nms-openwire/pull/3/files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-nms-openwire] michaelandrepearce commented on pull request #14: AMQNET-572 - Fix for NMS failover/TLS bug, by saving an Ssl context
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #14:
URL: https://github.com/apache/activemq-nms-openwire/pull/14#issuecomment-808504608
@brudo if youve managed to keep authorship thats actually better send a pr and well merge that one. I basically only did this quick because it seemed to go dormant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-nms-openwire] michaelandrepearce commented on pull request #14: AMQNET-572 - Fix for NMS failover/TLS bug, by saving an Ssl context
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #14:
URL: https://github.com/apache/activemq-nms-openwire/pull/14#issuecomment-809638016
@brudo i took your branch made a pr https://github.com/apache/activemq-nms-openwire/pull/16 and merged it. Much better to keep original author so thanks for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-nms-openwire] michaelandrepearce closed pull request #14: AMQNET-572 - Fix for NMS failover/TLS bug, by saving an Ssl context
Posted by GitBox <gi...@apache.org>.
michaelandrepearce closed pull request #14:
URL: https://github.com/apache/activemq-nms-openwire/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-nms-openwire] michaelandrepearce commented on pull request #14: AMQNET-572 - Fix for NMS failover/TLS bug, by saving an Ssl context
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #14:
URL: https://github.com/apache/activemq-nms-openwire/pull/14#issuecomment-805272440
@brudo - i tried to tidy up the original PR so it can be merged.
@lukeabsent - please also have a quick look, as per other PR, its been established the original solution is fine using thread static as the reconnect runs on single thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-nms-openwire] brudo commented on pull request #14: AMQNET-572 - Fix for NMS failover/TLS bug, by saving an Ssl context
Posted by GitBox <gi...@apache.org>.
brudo commented on pull request #14:
URL: https://github.com/apache/activemq-nms-openwire/pull/14#issuecomment-808502970
Cross posting... I looked, and it seems to be fine - essentially the same code as we have here, and the only downside I see is that @dtaflin no longer appears in the commit history. I did manage to preserve authorship in a commit my fork, here - brudo/activemq-nms-openwire@c60e83a - but I wasn't sure whether to submit that as a PR or not. Now, I think it would be redundant to add a third active PR on the same issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-nms-openwire] brudo commented on pull request #14: AMQNET-572 - Fix for NMS failover/TLS bug, by saving an Ssl context
Posted by GitBox <gi...@apache.org>.
brudo commented on pull request #14:
URL: https://github.com/apache/activemq-nms-openwire/pull/14#issuecomment-810349125
Wow, thanks yourself! I was slow to turn that around, and now it's done :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-nms-openwire] michaelandrepearce commented on pull request #14: AMQNET-572 - Fix for NMS failover/TLS bug, by saving an Ssl context
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #14:
URL: https://github.com/apache/activemq-nms-openwire/pull/14#issuecomment-805273120
original dated pr is here: https://github.com/apache/activemq-nms-openwire/pull/3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org