You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Daniel Kulp (JIRA)" <ji...@apache.org> on 2018/12/11 18:18:00 UTC

[jira] [Resolved] (AVRO-2034) Nested schema types with unexpected fields causes json parse failure

     [ https://issues.apache.org/jira/browse/AVRO-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp resolved AVRO-2034.
-------------------------------
       Resolution: Fixed
         Assignee: Daniel Kulp
    Fix Version/s: 1.9.0

> Nested schema types with unexpected fields causes json parse failure
> --------------------------------------------------------------------
>
>                 Key: AVRO-2034
>                 URL: https://issues.apache.org/jira/browse/AVRO-2034
>             Project: Apache Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.8.1
>            Reporter: Todd Nine
>            Assignee: Daniel Kulp
>            Priority: Major
>             Fix For: 1.9.0
>
>
> When parsing a nested type with an unexpected field using the JSON parser, this results in an error.  To reproduce, see the class {{TestNestedRecords}} in the referenced PR.
> https://github.com/apache/avro/pull/224
> Note that this only occurs when the following pattern exists in the schema.
> # regular field
> # nested record with additional field
> # Any subsequent field following the nested record with an unexpected field appears to reproduce the problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [jira] [Resolved] (AVRO-2034) Nested schema types with unexpected fields causes json parse failure

Posted by Daniel Kulp <dk...@apache.org>.

> On Dec 14, 2018, at 1:43 PM, Zoltan Farkas <zo...@yahoo.com.INVALID> wrote:
> 
> Daniel, can  you please take a look at my comment on this PR: https://github.com/apache/avro/pull/224/files <https://github.com/apache/avro/pull/224/files> ?
> 
> I believe there might still be issues with this implementation in certain situations.

Definitely a possibility.   The PR that was merged takes it a step further in allowing some constructs that would previously fail, but it may not fix 100% of the cases.   Feel free to create a test case and submit an additional PR.


-- 
Daniel Kulp
dkulp@apache.org <ma...@apache.org> - http://dankulp.com/blog <http://dankulp.com/blog>
Talend Community Coder - http://talend.com <http://coders.talend.com/>

Re: [jira] [Resolved] (AVRO-2034) Nested schema types with unexpected fields causes json parse failure

Posted by Zoltan Farkas <zo...@yahoo.com.INVALID>.
Daniel, can  you please take a look at my comment on this PR: https://github.com/apache/avro/pull/224/files <https://github.com/apache/avro/pull/224/files> ?

I believe there might still be issues with this implementation in certain situations.

Thanks!

—Z

> On Dec 11, 2018, at 1:18 PM, Daniel Kulp (JIRA) <ji...@apache.org> wrote:
> 
> 
>     [ https://issues.apache.org/jira/browse/AVRO-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
> 
> Daniel Kulp resolved AVRO-2034.
> -------------------------------
>       Resolution: Fixed
>         Assignee: Daniel Kulp
>    Fix Version/s: 1.9.0
> 
>> Nested schema types with unexpected fields causes json parse failure
>> --------------------------------------------------------------------
>> 
>>                Key: AVRO-2034
>>                URL: https://issues.apache.org/jira/browse/AVRO-2034
>>            Project: Apache Avro
>>         Issue Type: Bug
>>         Components: java
>>   Affects Versions: 1.8.1
>>           Reporter: Todd Nine
>>           Assignee: Daniel Kulp
>>           Priority: Major
>>            Fix For: 1.9.0
>> 
>> 
>> When parsing a nested type with an unexpected field using the JSON parser, this results in an error.  To reproduce, see the class {{TestNestedRecords}} in the referenced PR.
>> https://github.com/apache/avro/pull/224
>> Note that this only occurs when the following pattern exists in the schema.
>> # regular field
>> # nested record with additional field
>> # Any subsequent field following the nested record with an unexpected field appears to reproduce the problem.
> 
> 
> 
> --
> This message was sent by Atlassian JIRA
> (v7.6.3#76005)