[GitHub] [maven] cstamas commented on pull request #863: [MNG-7590] Allow to configure resolver by properties in settings.xml

[GitBox <gi...@apache.org>]

cstamas commented on PR #863:
URL: https://github.com/apache/maven/pull/863#issuecomment-1309864925

   Well, sorry for late as I missed: due https://issues.apache.org/jira/browse/MRESOLVER-284 this is not true for ANY settings.... as we talk here only about session config properties, but if you look at linked issue, some of config properties are expected from PlexusContext/SisuParameters.... this also means that this PR makes it impossible to have these expected as parameters to be set from settings.xml, and this is why I think is better thing to do:
   * on short term, to have all these in `$MAVEN_ARGS` or `.mvn/maven.conf` (or mavenrc)
   * on long term we need something dedicated I guess
   
   So, again, sorry, but I'd -1 this and rollback the commit as well, but am open to discussion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org