You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "jonvex (via GitHub)" <gi...@apache.org> on 2024/10/29 17:48:09 UTC

[PR] [HUDI-8456] add drop partition config if we are using fake partition [hudi]

jonvex opened a new pull request, #12178:
URL: https://github.com/apache/hudi/pull/12178

   ### Change Logs
   
   https://github.com/apache/hudi/pull/12176 seems like this might be really really difficult so will see if this direction is easier
   
   set drop partition when we use a fake partition column because the records don't actually contain that partition
   
   ### Impact
   
   tests reflect a real situation
   
   ### Risk level (write none, low medium or high below)
   
   low
   
   ### Documentation Update
   
   N/A
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-8456] add drop partition config if we are using fake partition [hudi]

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #12178:
URL: https://github.com/apache/hudi/pull/12178#discussion_r1823208888


##########
hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestUtils.java:
##########
@@ -204,6 +204,7 @@ public static HoodieTableMetaClient init(StorageConfiguration<?> storageConf, St
     if (!Objects.equals(keyGen, "org.apache.hudi.keygen.NonpartitionedKeyGenerator")
         && !properties.containsKey("hoodie.datasource.write.partitionpath.field")) {
       builder.setPartitionFields("some_nonexistent_field");
+      builder.setShouldDropPartitionColumns(true);

Review Comment:
   I think this should not be added as `hoodie.datasource.write.drop.partition.columns` is originally intended for compatibility with BigQuery only and it is seldomly used; there are other ways of making BigQuery read Hudi tables.  We should likely remove this write/table config.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-8456] add drop partition config if we are using fake partition [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12178:
URL: https://github.com/apache/hudi/pull/12178#issuecomment-2445223367

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "40e3506259e1030f63edf200230dc00ccaf1caf0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1456",
       "triggerID" : "40e3506259e1030f63edf200230dc00ccaf1caf0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "323cd4c0ad1393591a99ea200cd8bbf4b57cfba0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1457",
       "triggerID" : "323cd4c0ad1393591a99ea200cd8bbf4b57cfba0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac585ad9e32f104533bd36d7428a4c1098017596",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1458",
       "triggerID" : "ac585ad9e32f104533bd36d7428a4c1098017596",
       "triggerType" : "PUSH"
     }, {
       "hash" : "48e5d662f1d865046eb755b4344998f13e022526",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "48e5d662f1d865046eb755b4344998f13e022526",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ac585ad9e32f104533bd36d7428a4c1098017596 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1458) 
   * 48e5d662f1d865046eb755b4344998f13e022526 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-8456] add drop partition config if we are using fake partition [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12178:
URL: https://github.com/apache/hudi/pull/12178#issuecomment-2445070185

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "40e3506259e1030f63edf200230dc00ccaf1caf0",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1456",
       "triggerID" : "40e3506259e1030f63edf200230dc00ccaf1caf0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "323cd4c0ad1393591a99ea200cd8bbf4b57cfba0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "323cd4c0ad1393591a99ea200cd8bbf4b57cfba0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 40e3506259e1030f63edf200230dc00ccaf1caf0 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1456) 
   * 323cd4c0ad1393591a99ea200cd8bbf4b57cfba0 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-8456] add drop partition config if we are using fake partition [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12178:
URL: https://github.com/apache/hudi/pull/12178#issuecomment-2444961103

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "40e3506259e1030f63edf200230dc00ccaf1caf0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "40e3506259e1030f63edf200230dc00ccaf1caf0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 40e3506259e1030f63edf200230dc00ccaf1caf0 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-8456] add drop partition config if we are using fake partition [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12178:
URL: https://github.com/apache/hudi/pull/12178#issuecomment-2445305821

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "40e3506259e1030f63edf200230dc00ccaf1caf0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1456",
       "triggerID" : "40e3506259e1030f63edf200230dc00ccaf1caf0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "323cd4c0ad1393591a99ea200cd8bbf4b57cfba0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1457",
       "triggerID" : "323cd4c0ad1393591a99ea200cd8bbf4b57cfba0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac585ad9e32f104533bd36d7428a4c1098017596",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1458",
       "triggerID" : "ac585ad9e32f104533bd36d7428a4c1098017596",
       "triggerType" : "PUSH"
     }, {
       "hash" : "48e5d662f1d865046eb755b4344998f13e022526",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "48e5d662f1d865046eb755b4344998f13e022526",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80c9fd41c0db0f01a6c042168510f9c28136f745",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80c9fd41c0db0f01a6c042168510f9c28136f745",
       "triggerType" : "PUSH"
     }, {
       "hash" : "efc784d2c39ad04600c78b90e3df0bfdd141a953",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1461",
       "triggerID" : "efc784d2c39ad04600c78b90e3df0bfdd141a953",
       "triggerType" : "PUSH"
     }, {
       "hash" : "015aee14ab8f4bacb9a636d6e398e29e6067a5ba",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "015aee14ab8f4bacb9a636d6e398e29e6067a5ba",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ac585ad9e32f104533bd36d7428a4c1098017596 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1458) 
   * 48e5d662f1d865046eb755b4344998f13e022526 UNKNOWN
   * 80c9fd41c0db0f01a6c042168510f9c28136f745 UNKNOWN
   * efc784d2c39ad04600c78b90e3df0bfdd141a953 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1461) 
   * 015aee14ab8f4bacb9a636d6e398e29e6067a5ba UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-8456] add drop partition config if we are using fake partition [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12178:
URL: https://github.com/apache/hudi/pull/12178#issuecomment-2445173486

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "40e3506259e1030f63edf200230dc00ccaf1caf0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1456",
       "triggerID" : "40e3506259e1030f63edf200230dc00ccaf1caf0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "323cd4c0ad1393591a99ea200cd8bbf4b57cfba0",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1457",
       "triggerID" : "323cd4c0ad1393591a99ea200cd8bbf4b57cfba0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac585ad9e32f104533bd36d7428a4c1098017596",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac585ad9e32f104533bd36d7428a4c1098017596",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 323cd4c0ad1393591a99ea200cd8bbf4b57cfba0 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1457) 
   * ac585ad9e32f104533bd36d7428a4c1098017596 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-8456] add drop partition config if we are using fake partition [hudi]

Posted by "jonvex (via GitHub)" <gi...@apache.org>.
jonvex commented on code in PR #12178:
URL: https://github.com/apache/hudi/pull/12178#discussion_r1821548824


##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/BulkInsertDataInternalWriterHelper.java:
##########
@@ -100,22 +98,25 @@ public BulkInsertDataInternalWriterHelper(HoodieTable hoodieTable, HoodieWriteCo
     this.shouldPreserveHoodieMetadata = shouldPreserveHoodieMetadata;
     this.arePartitionRecordsSorted = arePartitionRecordsSorted;
     this.fileIdPrefix = UUID.randomUUID().toString();
+    this.shouldDropPartitionColumns = writeConfig.shouldDropPartitionColumns();
+    if (this.shouldDropPartitionColumns) {
+      // Drop the partition columns from the row
+      // Using the deprecated JavaConversions to be compatible with scala versions < 2.12. Once hudi support for scala versions < 2.12 is
+      // stopped, can move this to JavaConverters.seqAsJavaList(...)
+      List<String> partitionCols = JavaScalaConverters.convertScalaListToJavaList(HoodieDatasetBulkInsertHelper.getPartitionPathCols(this.writeConfig));
+      this.partitionIdx = new HashSet<>();
+      for (String col : partitionCols) {
+        partitionIdx.add(this.structType.fieldIndex(col));
+      }
+    } else {
+      this.partitionIdx = Collections.emptySet();
+    }
 
     if (!populateMetaFields) {
       this.keyGeneratorOpt = HoodieSparkKeyGeneratorFactory.getKeyGenerator(writeConfig.getProps());
     } else {
       this.keyGeneratorOpt = Option.empty();
     }
-
-    if (keyGeneratorOpt.isPresent() && keyGeneratorOpt.get() instanceof SimpleKeyGenerator) {
-      this.simpleKeyGen = true;

Review Comment:
   none of these are used by anything else



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-8456] add drop partition config if we are using fake partition [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12178:
URL: https://github.com/apache/hudi/pull/12178#issuecomment-2445269794

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "40e3506259e1030f63edf200230dc00ccaf1caf0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1456",
       "triggerID" : "40e3506259e1030f63edf200230dc00ccaf1caf0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "323cd4c0ad1393591a99ea200cd8bbf4b57cfba0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1457",
       "triggerID" : "323cd4c0ad1393591a99ea200cd8bbf4b57cfba0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac585ad9e32f104533bd36d7428a4c1098017596",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1458",
       "triggerID" : "ac585ad9e32f104533bd36d7428a4c1098017596",
       "triggerType" : "PUSH"
     }, {
       "hash" : "48e5d662f1d865046eb755b4344998f13e022526",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "48e5d662f1d865046eb755b4344998f13e022526",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80c9fd41c0db0f01a6c042168510f9c28136f745",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80c9fd41c0db0f01a6c042168510f9c28136f745",
       "triggerType" : "PUSH"
     }, {
       "hash" : "efc784d2c39ad04600c78b90e3df0bfdd141a953",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "efc784d2c39ad04600c78b90e3df0bfdd141a953",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ac585ad9e32f104533bd36d7428a4c1098017596 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1458) 
   * 48e5d662f1d865046eb755b4344998f13e022526 UNKNOWN
   * 80c9fd41c0db0f01a6c042168510f9c28136f745 UNKNOWN
   * efc784d2c39ad04600c78b90e3df0bfdd141a953 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-8456] add drop partition config if we are using fake partition [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12178:
URL: https://github.com/apache/hudi/pull/12178#issuecomment-2445477447

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "40e3506259e1030f63edf200230dc00ccaf1caf0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1456",
       "triggerID" : "40e3506259e1030f63edf200230dc00ccaf1caf0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "323cd4c0ad1393591a99ea200cd8bbf4b57cfba0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1457",
       "triggerID" : "323cd4c0ad1393591a99ea200cd8bbf4b57cfba0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac585ad9e32f104533bd36d7428a4c1098017596",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1458",
       "triggerID" : "ac585ad9e32f104533bd36d7428a4c1098017596",
       "triggerType" : "PUSH"
     }, {
       "hash" : "48e5d662f1d865046eb755b4344998f13e022526",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "48e5d662f1d865046eb755b4344998f13e022526",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80c9fd41c0db0f01a6c042168510f9c28136f745",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80c9fd41c0db0f01a6c042168510f9c28136f745",
       "triggerType" : "PUSH"
     }, {
       "hash" : "efc784d2c39ad04600c78b90e3df0bfdd141a953",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1461",
       "triggerID" : "efc784d2c39ad04600c78b90e3df0bfdd141a953",
       "triggerType" : "PUSH"
     }, {
       "hash" : "015aee14ab8f4bacb9a636d6e398e29e6067a5ba",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1462",
       "triggerID" : "015aee14ab8f4bacb9a636d6e398e29e6067a5ba",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 48e5d662f1d865046eb755b4344998f13e022526 UNKNOWN
   * 80c9fd41c0db0f01a6c042168510f9c28136f745 UNKNOWN
   * 015aee14ab8f4bacb9a636d6e398e29e6067a5ba Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1462) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-8456] add drop partition config if we are using fake partition [hudi]

Posted by "jonvex (via GitHub)" <gi...@apache.org>.
jonvex closed pull request #12178: [HUDI-8456] add drop partition config if we are using fake partition
URL: https://github.com/apache/hudi/pull/12178


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-8456] add drop partition config if we are using fake partition [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12178:
URL: https://github.com/apache/hudi/pull/12178#issuecomment-2445397833

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "40e3506259e1030f63edf200230dc00ccaf1caf0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1456",
       "triggerID" : "40e3506259e1030f63edf200230dc00ccaf1caf0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "323cd4c0ad1393591a99ea200cd8bbf4b57cfba0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1457",
       "triggerID" : "323cd4c0ad1393591a99ea200cd8bbf4b57cfba0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac585ad9e32f104533bd36d7428a4c1098017596",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1458",
       "triggerID" : "ac585ad9e32f104533bd36d7428a4c1098017596",
       "triggerType" : "PUSH"
     }, {
       "hash" : "48e5d662f1d865046eb755b4344998f13e022526",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "48e5d662f1d865046eb755b4344998f13e022526",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80c9fd41c0db0f01a6c042168510f9c28136f745",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80c9fd41c0db0f01a6c042168510f9c28136f745",
       "triggerType" : "PUSH"
     }, {
       "hash" : "efc784d2c39ad04600c78b90e3df0bfdd141a953",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1461",
       "triggerID" : "efc784d2c39ad04600c78b90e3df0bfdd141a953",
       "triggerType" : "PUSH"
     }, {
       "hash" : "015aee14ab8f4bacb9a636d6e398e29e6067a5ba",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1462",
       "triggerID" : "015aee14ab8f4bacb9a636d6e398e29e6067a5ba",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 48e5d662f1d865046eb755b4344998f13e022526 UNKNOWN
   * 80c9fd41c0db0f01a6c042168510f9c28136f745 UNKNOWN
   * efc784d2c39ad04600c78b90e3df0bfdd141a953 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1461) 
   * 015aee14ab8f4bacb9a636d6e398e29e6067a5ba Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1462) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-8456] add drop partition config if we are using fake partition [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12178:
URL: https://github.com/apache/hudi/pull/12178#issuecomment-2444964404

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "40e3506259e1030f63edf200230dc00ccaf1caf0",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1456",
       "triggerID" : "40e3506259e1030f63edf200230dc00ccaf1caf0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 40e3506259e1030f63edf200230dc00ccaf1caf0 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1456) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-8456] add drop partition config if we are using fake partition [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12178:
URL: https://github.com/apache/hudi/pull/12178#issuecomment-2445072901

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "40e3506259e1030f63edf200230dc00ccaf1caf0",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1456",
       "triggerID" : "40e3506259e1030f63edf200230dc00ccaf1caf0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "323cd4c0ad1393591a99ea200cd8bbf4b57cfba0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "323cd4c0ad1393591a99ea200cd8bbf4b57cfba0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 40e3506259e1030f63edf200230dc00ccaf1caf0 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1456) 
   * 323cd4c0ad1393591a99ea200cd8bbf4b57cfba0 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-8456] add drop partition config if we are using fake partition [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12178:
URL: https://github.com/apache/hudi/pull/12178#issuecomment-2445308479

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "40e3506259e1030f63edf200230dc00ccaf1caf0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1456",
       "triggerID" : "40e3506259e1030f63edf200230dc00ccaf1caf0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "323cd4c0ad1393591a99ea200cd8bbf4b57cfba0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1457",
       "triggerID" : "323cd4c0ad1393591a99ea200cd8bbf4b57cfba0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac585ad9e32f104533bd36d7428a4c1098017596",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1458",
       "triggerID" : "ac585ad9e32f104533bd36d7428a4c1098017596",
       "triggerType" : "PUSH"
     }, {
       "hash" : "48e5d662f1d865046eb755b4344998f13e022526",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "48e5d662f1d865046eb755b4344998f13e022526",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80c9fd41c0db0f01a6c042168510f9c28136f745",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80c9fd41c0db0f01a6c042168510f9c28136f745",
       "triggerType" : "PUSH"
     }, {
       "hash" : "efc784d2c39ad04600c78b90e3df0bfdd141a953",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1461",
       "triggerID" : "efc784d2c39ad04600c78b90e3df0bfdd141a953",
       "triggerType" : "PUSH"
     }, {
       "hash" : "015aee14ab8f4bacb9a636d6e398e29e6067a5ba",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "015aee14ab8f4bacb9a636d6e398e29e6067a5ba",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 48e5d662f1d865046eb755b4344998f13e022526 UNKNOWN
   * 80c9fd41c0db0f01a6c042168510f9c28136f745 UNKNOWN
   * efc784d2c39ad04600c78b90e3df0bfdd141a953 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1461) 
   * 015aee14ab8f4bacb9a636d6e398e29e6067a5ba UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-8456] add drop partition config if we are using fake partition [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12178:
URL: https://github.com/apache/hudi/pull/12178#issuecomment-2445081411

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "40e3506259e1030f63edf200230dc00ccaf1caf0",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1456",
       "triggerID" : "40e3506259e1030f63edf200230dc00ccaf1caf0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "323cd4c0ad1393591a99ea200cd8bbf4b57cfba0",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1457",
       "triggerID" : "323cd4c0ad1393591a99ea200cd8bbf4b57cfba0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 40e3506259e1030f63edf200230dc00ccaf1caf0 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1456) 
   * 323cd4c0ad1393591a99ea200cd8bbf4b57cfba0 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1457) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-8456] add drop partition config if we are using fake partition [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12178:
URL: https://github.com/apache/hudi/pull/12178#issuecomment-2445170616

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "40e3506259e1030f63edf200230dc00ccaf1caf0",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1456",
       "triggerID" : "40e3506259e1030f63edf200230dc00ccaf1caf0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "323cd4c0ad1393591a99ea200cd8bbf4b57cfba0",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1457",
       "triggerID" : "323cd4c0ad1393591a99ea200cd8bbf4b57cfba0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac585ad9e32f104533bd36d7428a4c1098017596",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac585ad9e32f104533bd36d7428a4c1098017596",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 40e3506259e1030f63edf200230dc00ccaf1caf0 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1456) 
   * 323cd4c0ad1393591a99ea200cd8bbf4b57cfba0 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1457) 
   * ac585ad9e32f104533bd36d7428a4c1098017596 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-8456] add drop partition config if we are using fake partition [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12178:
URL: https://github.com/apache/hudi/pull/12178#issuecomment-2445196806

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "40e3506259e1030f63edf200230dc00ccaf1caf0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1456",
       "triggerID" : "40e3506259e1030f63edf200230dc00ccaf1caf0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "323cd4c0ad1393591a99ea200cd8bbf4b57cfba0",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1457",
       "triggerID" : "323cd4c0ad1393591a99ea200cd8bbf4b57cfba0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac585ad9e32f104533bd36d7428a4c1098017596",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1458",
       "triggerID" : "ac585ad9e32f104533bd36d7428a4c1098017596",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 323cd4c0ad1393591a99ea200cd8bbf4b57cfba0 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1457) 
   * ac585ad9e32f104533bd36d7428a4c1098017596 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1458) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-8456] add drop partition config if we are using fake partition [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12178:
URL: https://github.com/apache/hudi/pull/12178#issuecomment-2445220489

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "40e3506259e1030f63edf200230dc00ccaf1caf0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1456",
       "triggerID" : "40e3506259e1030f63edf200230dc00ccaf1caf0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "323cd4c0ad1393591a99ea200cd8bbf4b57cfba0",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1457",
       "triggerID" : "323cd4c0ad1393591a99ea200cd8bbf4b57cfba0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac585ad9e32f104533bd36d7428a4c1098017596",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1458",
       "triggerID" : "ac585ad9e32f104533bd36d7428a4c1098017596",
       "triggerType" : "PUSH"
     }, {
       "hash" : "48e5d662f1d865046eb755b4344998f13e022526",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "48e5d662f1d865046eb755b4344998f13e022526",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 323cd4c0ad1393591a99ea200cd8bbf4b57cfba0 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1457) 
   * ac585ad9e32f104533bd36d7428a4c1098017596 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1458) 
   * 48e5d662f1d865046eb755b4344998f13e022526 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-8456] add drop partition config if we are using fake partition [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12178:
URL: https://github.com/apache/hudi/pull/12178#issuecomment-2445261913

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "40e3506259e1030f63edf200230dc00ccaf1caf0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1456",
       "triggerID" : "40e3506259e1030f63edf200230dc00ccaf1caf0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "323cd4c0ad1393591a99ea200cd8bbf4b57cfba0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1457",
       "triggerID" : "323cd4c0ad1393591a99ea200cd8bbf4b57cfba0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac585ad9e32f104533bd36d7428a4c1098017596",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1458",
       "triggerID" : "ac585ad9e32f104533bd36d7428a4c1098017596",
       "triggerType" : "PUSH"
     }, {
       "hash" : "48e5d662f1d865046eb755b4344998f13e022526",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "48e5d662f1d865046eb755b4344998f13e022526",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80c9fd41c0db0f01a6c042168510f9c28136f745",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80c9fd41c0db0f01a6c042168510f9c28136f745",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ac585ad9e32f104533bd36d7428a4c1098017596 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1458) 
   * 48e5d662f1d865046eb755b4344998f13e022526 UNKNOWN
   * 80c9fd41c0db0f01a6c042168510f9c28136f745 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-8456] add drop partition config if we are using fake partition [hudi]

Posted by "jonvex (via GitHub)" <gi...@apache.org>.
jonvex commented on code in PR #12178:
URL: https://github.com/apache/hudi/pull/12178#discussion_r1821548532


##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/BulkInsertDataInternalWriterHelper.java:
##########
@@ -100,22 +98,25 @@ public BulkInsertDataInternalWriterHelper(HoodieTable hoodieTable, HoodieWriteCo
     this.shouldPreserveHoodieMetadata = shouldPreserveHoodieMetadata;
     this.arePartitionRecordsSorted = arePartitionRecordsSorted;
     this.fileIdPrefix = UUID.randomUUID().toString();
+    this.shouldDropPartitionColumns = writeConfig.shouldDropPartitionColumns();

Review Comment:
   Pulled this out of the loop to reduce recomputation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org