You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/11/18 17:23:24 UTC

[GitHub] [lucene] zhaih opened a new pull request #454: LUCENE-10122 Use NumericDocValue to store taxonomy parent array

zhaih opened a new pull request #454:
URL: https://github.com/apache/lucene/pull/454


   # Note
   PR towards branch_9x, mostly the same as https://github.com/apache/lucene/pull/442, adding one additional assertion to make sure when checking the index version the index is not empty
   
   # Checklist
   
   Please review the following and check all that apply:
   ](https://github.com/apache/lucene/pull/442)
   - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request title.
   - [x] I have given Lucene maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `main` branch.
   - [x] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] mikemccand merged pull request #454: LUCENE-10122 Use NumericDocValue to store taxonomy parent array

Posted by GitBox <gi...@apache.org>.
mikemccand merged pull request #454:
URL: https://github.com/apache/lucene/pull/454


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] mikemccand commented on pull request #454: LUCENE-10122 Use NumericDocValue to store taxonomy parent array

Posted by GitBox <gi...@apache.org>.
mikemccand commented on pull request #454:
URL: https://github.com/apache/lucene/pull/454#issuecomment-974291679


   OK I get it!  We already pushed this awesome change to 9.0 branch, main branch, and this one is for 9.x branch!  Thanks @zhaih!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org